A platform for community discussion. Free, open, simple.
SECURITY: PostsController#raw_email leaks raw emails of inaccessible to mods (#41962)
Sam01632b1bc6d8
diff --git a/app/controllers/posts_controller.rb b/app/controllers/posts_controller.rbindex a98de26e8c6..17c3a01899a 100644--- a/app/controllers/posts_controller.rb+++ b/app/controllers/posts_controller.rb@@ -174,6 +174,7 @@ class PostsController < ApplicationControllerdef raw_emailparams.require(:id)post = Post.unscoped.find(params[:id].to_i)+ guardian.ensure_can_see!(post)guardian.ensure_can_view_raw_email!(post)text, html = Email.extract_parts(post.raw_email)render json: { raw_email: post.raw_email, text_part: text, html_part: html }diff --git a/spec/requests/posts_controller_spec.rb b/spec/requests/posts_controller_spec.rbindex 5ee1abac2dd..3dc536894d8 100644--- a/spec/requests/posts_controller_spec.rb+++ b/spec/requests/posts_controller_spec.rb@@ -4109,11 +4109,39 @@ RSpec.describe PostsController doexpect(response.status).to eq(403)end- it "can view raw email if the user is in the allowed group" do+ it "blocks raw email for unseen private messages" do+ raw_email = "From: [email protected]\nTo: [email protected]\n\nsecret body"+ private_message_post =+ Fabricate(+ :private_message_post,+ user: user,+ recipient: Fabricate(:user),+ raw_email: raw_email,+ )+ sign_in(moderator)++ get "/posts/#{private_message_post.id}/raw-email.json"++ expect(response.status).to eq(403)+ expect(response.body).not_to include(raw_email)+ end++ it "blocks deleted raw email for allowed non-staff users" dosign_in(user)SiteSetting.view_raw_email_allowed_groups = "trust_level_0"get "/posts/#{post.id}/raw-email.json"++ expect(response.status).to eq(403)+ expect(response.body).not_to include(post.raw_email)+ end++ it "can view raw email if the user is in the allowed group" do+ allowed_post = Fabricate(:post, user: Fabricate(:user), raw_email: "email_content")+ sign_in(user)+ SiteSetting.view_raw_email_allowed_groups = "trust_level_0"++ get "/posts/#{allowed_post.id}/raw-email.json"expect(response.status).to eq(200)json = response.parsed_body