Skip to content

A platform for community discussion. Free, open, simple.

DEV: Deduplicate in: filters in advanced search (#38442)

Isaac Janzen025db78be77a
diff --git a/frontend/discourse/app/components/search-advanced-options.gjs b/frontend/discourse/app/components/search-advanced-options.gjs
index 7f2d359eb99..c7def014ce5 100644
--- a/frontend/discourse/app/components/search-advanced-options.gjs
+++ b/frontend/discourse/app/components/search-advanced-options.gjs
@@ -246,7 +246,7 @@ export default class SearchAdvancedOptions extends Component {
if (value === "personal") {
value = "messages";
}
- if (validValues.includes(value)) {
+ if (validValues.includes(value) && !selectedFilters.includes(value)) {
selectedFilters.push(value);
}
}
diff --git a/frontend/discourse/tests/acceptance/search-full-test.js b/frontend/discourse/tests/acceptance/search-full-test.js
index 5b0b97af6c5..d322a289730 100644
--- a/frontend/discourse/tests/acceptance/search-full-test.js
+++ b/frontend/discourse/tests/acceptance/search-full-test.js
@@ -356,6 +356,29 @@ acceptance("Search - Full Page", function (needs) {
.hasValue("none in:likes", "removes deselected filter from search term");
});
+ test("duplicate in: filters in search term are deduplicated", async function (assert) {
+ const inSelector = selectKit(IN_OPTIONS_SELECTOR);
+
+ await visit("/search?expanded=true");
+ await fillIn(".search-query", "test in:likes in:likes in:title in:title");
+
+ assert.strictEqual(
+ inSelector.header().value(),
+ "likes,title",
+ "deduplicates filters in the multi-select"
+ );
+
+ await inSelector.expand();
+ await inSelector.selectRowByValue("seen");
+
+ assert
+ .dom(".search-query")
+ .hasValue(
+ "test in:likes in:title in:seen",
+ "deduplicates filters in the search term when user interacts with the filter"
+ );
+ });
+
test("update status through advanced search UI", async function (assert) {
const statusSelector = selectKit(
".search-advanced-options .select-kit#search-status-options"