Skip to content

A platform for community discussion. Free, open, simple.

FIX: Allow fullApp embed iframe to shrink with content (#39376)

Rafael dos Santos Silva03cc99866fe0
diff --git a/frontend/discourse/app/instance-initializers/embed-mode-resize.js b/frontend/discourse/app/instance-initializers/embed-mode-resize.js
index ca40d3a940b..eeb57fb8843 100644
--- a/frontend/discourse/app/instance-initializers/embed-mode-resize.js
+++ b/frontend/discourse/app/instance-initializers/embed-mode-resize.js
@@ -1,15 +1,44 @@
import EmbedMode from "discourse/lib/embed-mode";
+const THROTTLE_MS = 1000;
+const MAX_MESSAGES = 10;
+
let resizeObserver;
+let trailingTimeout;
+let lastSentAt = 0;
+let messageCount = 0;
-function postHeight() {
+function sendHeightMessage(element) {
if (parent === window) {
return;
}
+ messageCount++;
+ lastSentAt = Date.now();
parent.postMessage(
- { type: "discourse-resize", height: document.body.scrollHeight },
+ { type: "discourse-resize", height: element.scrollHeight },
"*"
);
+ if (messageCount >= MAX_MESSAGES) {
+ resizeObserver?.disconnect();
+ resizeObserver = null;
+ }
+}
+
+function scheduleHeightMessage(element) {
+ if (messageCount >= MAX_MESSAGES) {
+ return;
+ }
+ const elapsed = Date.now() - lastSentAt;
+ if (elapsed >= THROTTLE_MS) {
+ clearTimeout(trailingTimeout);
+ trailingTimeout = null;
+ sendHeightMessage(element);
+ } else if (!trailingTimeout) {
+ trailingTimeout = setTimeout(() => {
+ trailingTimeout = null;
+ sendHeightMessage(element);
+ }, THROTTLE_MS - elapsed);
+ }
}
export default {
@@ -18,12 +47,23 @@ export default {
return;
}
- resizeObserver = new ResizeObserver(postHeight);
- resizeObserver.observe(document.body);
+ // The body grows with the iframe, so measuring it prevents shrinking.
+ // Observe the Ember root element instead to report actual content height.
+ const element = document.querySelector("#main");
+ if (!element) {
+ return;
+ }
+
+ resizeObserver = new ResizeObserver(() => scheduleHeightMessage(element));
+ resizeObserver.observe(element);
},
teardown() {
resizeObserver?.disconnect();
resizeObserver = null;
+ clearTimeout(trailingTimeout);
+ trailingTimeout = null;
+ lastSentAt = 0;
+ messageCount = 0;
},
};