Skip to content

A platform for community discussion. Free, open, simple.

DEV: Add missing return in getConsolePrefix (#38438)

Isaac Janzen041022fafd58
diff --git a/frontend/discourse/app/lib/deprecated.js b/frontend/discourse/app/lib/deprecated.js
index 940a05e9ee7..4b4c44039fc 100644
--- a/frontend/discourse/app/lib/deprecated.js
+++ b/frontend/discourse/app/lib/deprecated.js
@@ -177,7 +177,7 @@ function buildDeprecationMessage(msg, options, raiseError) {
* @returns {String} The console prefix
*/
function getConsolePrefix(source) {
- consolePrefix(null, source) || "";
+ return consolePrefix(null, source) || "";
}
/**
diff --git a/frontend/discourse/tests/unit/lib/deprecated-test.js b/frontend/discourse/tests/unit/lib/deprecated-test.js
index 52d10f8093c..043a4af5a9e 100644
--- a/frontend/discourse/tests/unit/lib/deprecated-test.js
+++ b/frontend/discourse/tests/unit/lib/deprecated-test.js
@@ -134,6 +134,23 @@ module("Unit | Utility | deprecated", function (hooks) {
);
});
+ test("includes console prefix from source identifier", function (assert) {
+ deprecated("My message", {
+ id: "discourse.test",
+ source: {
+ type: "theme",
+ id: "123",
+ name: "test-theme",
+ path: "/admin/customize/themes/123?safe_mode=no_themes",
+ },
+ });
+ assert.strictEqual(this.warnStub.callCount, 1);
+ assert.deepEqual(this.warnStub.args[0], [
+ "[THEME 123 'test-theme']",
+ "DEPRECATION NOTICE: My message [deprecation id: discourse.test]",
+ ]);
+ });
+
test("can silence individual deprecations in tests", function (assert) {
withSilencedDeprecations("discourse.one", () =>
deprecated("message", { id: "discourse.one" })