Skip to content

A platform for community discussion. Free, open, simple.

DEV: Improvements/fixes for automatic upcoming change status bumping (#40920)

Martin Brennan04be6dbda6c9
diff --git a/.github/workflows/upcoming-change-status-bump.yml b/.github/workflows/upcoming-change-status-bump.yml
index 07229d320a1..2b5ce7bd439 100644
--- a/.github/workflows/upcoming-change-status-bump.yml
+++ b/.github/workflows/upcoming-change-status-bump.yml
@@ -66,25 +66,10 @@ jobs:
- name: Generate status report
id: report
- run: |
- bin/rails runner script/upcoming_changes_status_report -- \
- --stale-after-days "${{ steps.config.outputs.stale_after_days }}" \
- --pretty > /tmp/upcoming_changes_status_report.json
-
- cat /tmp/upcoming_changes_status_report.json
-
- eligible_count="$(jq '[.[] | select(.eligible)] | length' /tmp/upcoming_changes_status_report.json)"
- echo "eligible_count=${eligible_count}" >> "${GITHUB_OUTPUT}"
-
- {
- echo "### Upcoming change status report"
- echo
- echo "- Dry run: \`${{ steps.config.outputs.dry_run }}\`"
- echo "- Stale after days: \`${{ steps.config.outputs.stale_after_days }}\`"
- echo "- Eligible changes: \`${eligible_count}\`"
- echo
- jq -r '.[] | select(.eligible) | "- `\(.name)`: `\(.current_status)` -> `\(.next_status)` in `\(.settings_path)`; last changed \(.days_since_status_change) days ago"' /tmp/upcoming_changes_status_report.json
- } >> "${GITHUB_STEP_SUMMARY}"
+ run: script/generate_upcoming_change_status_report
+ env:
+ DRY_RUN: ${{ steps.config.outputs.dry_run }}
+ STALE_AFTER_DAYS: ${{ steps.config.outputs.stale_after_days }}
- name: Create or print pull requests
if: steps.report.outputs.eligible_count != '0'
diff --git a/script/generate_upcoming_change_status_report b/script/generate_upcoming_change_status_report
new file mode 100755
index 00000000000..80e3f5b024e
--- /dev/null
+++ b/script/generate_upcoming_change_status_report
@@ -0,0 +1,30 @@
+#!/usr/bin/env sh
+set -eu
+
+stale_after_days="${STALE_AFTER_DAYS:-14}"
+dry_run="${DRY_RUN:-true}"
+
+bin/rails runner script/upcoming_changes_status_report -- \
+ --stale-after-days "${stale_after_days}" \
+ --pretty > /tmp/upcoming_changes_status_report.json
+
+cat /tmp/upcoming_changes_status_report.json
+
+eligible_count="$(
+ ruby -rjson -e 'records = JSON.parse(File.read(ARGV.fetch(0))); puts records.count { |record| record["eligible"] }' /tmp/upcoming_changes_status_report.json
+)"
+echo "eligible_count=${eligible_count}" >> "${GITHUB_OUTPUT}"
+
+{
+ echo "### Upcoming change status report"
+ echo
+ echo "- Dry run: \`${dry_run}\`"
+ echo "- Stale after days: \`${stale_after_days}\`"
+ echo "- Eligible changes: \`${eligible_count}\`"
+ echo
+ ruby -rjson -e '
+ JSON.parse(File.read(ARGV.fetch(0))).select { |record| record["eligible"] }.each do |record|
+ puts "- `#{record["name"]}`: `#{record["current_status"]}` -> `#{record["next_status"]}` in `#{record["settings_path"]}`; last changed #{record["days_since_status_change"]} days ago"
+ end
+ ' /tmp/upcoming_changes_status_report.json
+} >> "${GITHUB_STEP_SUMMARY}"
\ No newline at end of file