Skip to content

A platform for community discussion. Free, open, simple.

PERF: Avoid timeout when deleting a house ad with many impressions (#39996)

ducks05e4a3d98e78
diff --git a/plugins/discourse-adplugin/app/models/ad_plugin/house_ad.rb b/plugins/discourse-adplugin/app/models/ad_plugin/house_ad.rb
index a10ddccaa81..57c63a92fbb 100644
--- a/plugins/discourse-adplugin/app/models/ad_plugin/house_ad.rb
+++ b/plugins/discourse-adplugin/app/models/ad_plugin/house_ad.rb
@@ -15,7 +15,7 @@ module AdPlugin
has_many :impressions,
class_name: "AdPlugin::AdImpression",
foreign_key: "ad_plugin_house_ad_id",
- dependent: :destroy
+ dependent: :delete_all
has_many :routes,
class_name: "AdPlugin::HouseAdRoute",
diff --git a/plugins/discourse-adplugin/spec/models/house_ad_spec.rb b/plugins/discourse-adplugin/spec/models/house_ad_spec.rb
index 4e6050d2462..4d86e155b0f 100644
--- a/plugins/discourse-adplugin/spec/models/house_ad_spec.rb
+++ b/plugins/discourse-adplugin/spec/models/house_ad_spec.rb
@@ -353,4 +353,23 @@ describe AdPlugin::HouseAd do
expect { ad.destroy }.to change { AdPlugin::HouseAdRoute.count }.by(-1)
end
end
+
+ describe "destroying with associated impressions" do
+ fab!(:ad, :house_ad)
+
+ it "deletes impressions in a single DELETE query" do
+ 3.times { Fabricate(:anonymous_house_ad_impression, house_ad: ad) }
+
+ delete_queries = nil
+
+ expect do
+ delete_queries =
+ track_sql_queries { ad.destroy! }.select do |sql|
+ sql.match?(/DELETE FROM ["']?ad_plugin_impressions["']?/i)
+ end
+ end.to change { AdPlugin::AdImpression.count }.by(-3)
+
+ expect(delete_queries.size).to eq(1)
+ end
+ end
end