Skip to content

A platform for community discussion. Free, open, simple.

UX: Fix site traffic dimension label spacing (#42575)

Alan Guo Xiang Tan08063dd6e62b
diff --git a/app/assets/stylesheets/admin/dashboard/site-traffic-explorer.scss b/app/assets/stylesheets/admin/dashboard/site-traffic-explorer.scss
index 249bc8962cc..fc0046edc85 100644
--- a/app/assets/stylesheets/admin/dashboard/site-traffic-explorer.scss
+++ b/app/assets/stylesheets/admin/dashboard/site-traffic-explorer.scss
@@ -317,17 +317,20 @@
}
&__dimension-label {
- display: grid;
- grid-template-columns: auto minmax(0, 1fr);
+ display: flex;
align-items: center;
- gap: var(--space-2);
min-width: 0;
width: 100%;
}
+ &__dimension-prefix {
+ flex: 0 0 auto;
+ margin-inline-end: var(--space-2);
+ }
+
&__dimension-text {
@include ellipsis;
- grid-column: 2;
+ flex: 1 1 auto;
min-width: 0;
}
diff --git a/frontend/discourse/admin/components/site-traffic-explorer-dimension-label.gjs b/frontend/discourse/admin/components/site-traffic-explorer-dimension-label.gjs
index 7c4f3c46132..08654db518e 100644
--- a/frontend/discourse/admin/components/site-traffic-explorer-dimension-label.gjs
+++ b/frontend/discourse/admin/components/site-traffic-explorer-dimension-label.gjs
@@ -26,9 +26,15 @@ export default class SiteTrafficExplorerDimensionLabel extends Component {
<template>
<span class="site-traffic-explorer__dimension-label">
{{#if (eq @dimension "countries")}}
- <span aria-hidden="true">{{this.countryFlag @row.value}}</span>
+ <span
+ class="site-traffic-explorer__dimension-prefix"
+ aria-hidden="true"
+ >{{this.countryFlag @row.value}}</span>
{{else if (eq @dimension "browsers")}}
- {{dIcon (this.browserIcon @row.value)}}
+ {{dIcon
+ (this.browserIcon @row.value)
+ class="site-traffic-explorer__dimension-prefix"
+ }}
{{/if}}
<span class="site-traffic-explorer__dimension-text" title={{@row.label}}>
{{@row.label}}