Skip to content

A platform for community discussion. Free, open, simple.

DEV: resolve array deprecation on the AI embeddings edit page (#43115)

David Taylor0af00cdda06c
diff --git a/plugins/discourse-ai/admin/assets/javascripts/discourse/routes/admin-plugins/show/discourse-ai-embeddings/edit.js b/plugins/discourse-ai/admin/assets/javascripts/discourse/routes/admin-plugins/show/discourse-ai-embeddings/edit.js
index 7fcf63fb1d6..3a99bd2d7d6 100644
--- a/plugins/discourse-ai/admin/assets/javascripts/discourse/routes/admin-plugins/show/discourse-ai-embeddings/edit.js
+++ b/plugins/discourse-ai/admin/assets/javascripts/discourse/routes/admin-plugins/show/discourse-ai-embeddings/edit.js
@@ -6,7 +6,7 @@ export default class AdminPluginsShowDiscourseAiEmbeddingsEdit extends Discourse
"adminPlugins.show.discourse-ai-embeddings"
);
const id = parseInt(params.id, 10);
- const record = allEmbeddings.find((item) => item.id === id);
+ const record = allEmbeddings.content.find((item) => item.id === id);
record.provider_params = record.provider_params || {};
return record;
}
diff --git a/plugins/discourse-ai/spec/system/embeddings/ai_embedding_definition_spec.rb b/plugins/discourse-ai/spec/system/embeddings/ai_embedding_definition_spec.rb
index dd8d5aa9180..1571abeb2d3 100644
--- a/plugins/discourse-ai/spec/system/embeddings/ai_embedding_definition_spec.rb
+++ b/plugins/discourse-ai/spec/system/embeddings/ai_embedding_definition_spec.rb
@@ -92,4 +92,18 @@ RSpec.describe "Managing Embeddings configurations" do
expect(embedding_def.embed_prompt).to eq(embed_prefix)
expect(embedding_def.search_prompt).to eq(search_prefix)
end
+
+ it "supports editing an existing configuration" do
+ embedding_def = Fabricate(:embedding_definition)
+
+ visit "/admin/plugins/discourse-ai/ai-embeddings/#{embedding_def.id}/edit"
+
+ form.field("display_name").fill_in("Updated embeddings")
+ form.submit
+
+ expect(PageObjects::Components::Toasts.new).to have_success(
+ I18n.t("js.discourse_ai.embeddings.saved"),
+ )
+ expect(embedding_def.reload.display_name).to eq("Updated embeddings")
+ end
end