A platform for community discussion. Free, open, simple.
SECURITY: Check topic visibility in Oneboxer even when categories match
Natalie Tay0b4e6ff17036
diff --git a/lib/oneboxer.rb b/lib/oneboxer.rbindex e8c4dda278e..9c79e2fde09 100644--- a/lib/oneboxer.rb+++ b/lib/oneboxer.rb@@ -365,6 +365,8 @@ module Oneboxerif current_category.blank? || current_category.id != topic.category_idreturn unless Guardian.new.can_see_topic?(topic)+ else+ return unless Guardian.new(current_user).can_see_topic?(topic)endtopicdiff --git a/spec/requests/inline_onebox_controller_spec.rb b/spec/requests/inline_onebox_controller_spec.rbindex 5d6d2a2ab58..e23c0ea8c88 100644--- a/spec/requests/inline_onebox_controller_spec.rb+++ b/spec/requests/inline_onebox_controller_spec.rb@@ -132,5 +132,32 @@ RSpec.describe InlineOneboxController doexpect(onebox["title"]).to eq(topic.title)endend++ context "with shared draft topic" do+ fab!(:shared_drafts_category, :category)+ fab!(:destination_category, :category)+ fab!(:shared_draft_topic) { Fabricate(:topic, category: shared_drafts_category) }+ fab!(:shared_draft_post) { Fabricate(:post, topic: shared_draft_topic) }+ fab!(:shared_draft) do+ Fabricate(:shared_draft, topic: shared_draft_topic, category: destination_category)+ end++ before do+ SiteSetting.shared_drafts_category = shared_drafts_category.id+ SiteSetting.shared_drafts_allowed_groups = Group::AUTO_GROUPS[:staff]+ end++ it "does not leak shared draft topic titles via user-controlled category_id" do+ get "/inline-onebox.json",+ params: {+ urls: [shared_draft_topic.url],+ category_id: shared_drafts_category.id,+ }++ expect(response.status).to eq(200)+ json = response.parsed_body+ expect(json["inline-oneboxes"][0]).to be_blank+ end+ endendend