Skip to content

A platform for community discussion. Free, open, simple.

DEV: Ensure multiple rolldown devservers cannot run concurrently (#41913)

David Taylor0ba2b5a76b38
diff --git a/frontend/discourse/lib/rolldown-devserver-lock.mjs b/frontend/discourse/lib/rolldown-devserver-lock.mjs
new file mode 100644
index 00000000000..42170588648
--- /dev/null
+++ b/frontend/discourse/lib/rolldown-devserver-lock.mjs
@@ -0,0 +1,35 @@
+import * as fs from "fs";
+
+export const MANIFEST_DIR = "./dist/manifest";
+export const BUILD_STATUS_FILE = `${MANIFEST_DIR}/build.json`;
+
+function isProcessRunning(pid) {
+ try {
+ // Signal 0 checks whether the process exists without sending a signal.
+ process.kill(pid, 0);
+ return true;
+ } catch (e) {
+ // ESRCH means nothing owns the pid (a stale status file). EPERM means it's
+ // owned by another user, i.e. still running.
+ return e.code !== "ESRCH";
+ }
+}
+
+export function exitIfDevServerRunning() {
+ let existing;
+ try {
+ existing = JSON.parse(fs.readFileSync(BUILD_STATUS_FILE, "utf8"));
+ } catch {
+ return;
+ }
+
+ const { pid } = existing;
+ if (pid && isProcessRunning(pid)) {
+ // eslint-disable-next-line no-console
+ console.error(
+ `rolldown devserver is already running on pid=${pid}. Stop it before ` +
+ `starting another build, or delete ${BUILD_STATUS_FILE} if it's stale.`
+ );
+ process.exit(1);
+ }
+}
diff --git a/frontend/discourse/rolldown.config.mjs b/frontend/discourse/rolldown.config.mjs
index e48dfbb7ccd..7b12f831ef7 100644
--- a/frontend/discourse/rolldown.config.mjs
+++ b/frontend/discourse/rolldown.config.mjs
@@ -6,8 +6,11 @@ import dynamicChunkUrlPlugin from "./lib/dynamic-chunk-url-plugin.mjs";
import writeResolverConfig from "./lib/embroider-vite-resolver-options.mjs";
import maybeBabel from "./lib/maybe-babel.mjs";
import optimizedEmber from "./lib/optimized-ember.mjs";
+import { exitIfDevServerRunning } from "./lib/rolldown-devserver-lock.mjs";
import wrapTestModulesPlugin from "./lib/wrap-test-modules-plugin.mjs";
+exitIfDevServerRunning();
+
writeResolverConfig(
{
staticAppPaths: ["static", "admin", "workers"],
diff --git a/frontend/discourse/rolldown.mjs b/frontend/discourse/rolldown.mjs
index 91515bcfb72..2df2888dfb5 100755
--- a/frontend/discourse/rolldown.mjs
+++ b/frontend/discourse/rolldown.mjs
@@ -5,12 +5,14 @@ import AnsiToHtml from "ansi-to-html";
import * as fs from "fs";
import * as path from "path";
import { dev } from "rolldown/experimental";
+import {
+ BUILD_STATUS_FILE,
+ MANIFEST_DIR,
+} from "./lib/rolldown-devserver-lock.mjs";
import { buildConfig } from "./rolldown.config.mjs";
const ansiConverter = new AnsiToHtml({ newline: true, escapeXML: true });
const CWD_PREFIX = `${process.cwd()}/`;
-const MANIFEST_DIR = "./dist/manifest";
-const BUILD_STATUS_FILE = `${MANIFEST_DIR}/build.json`;
let buildStart = Date.now();
let initialBuild = true;