Skip to content

A platform for community discussion. Free, open, simple.

DEV: Try to catch a search-menu-test flake (#40883)

Jarek Radosz0e690ee408fc
diff --git a/frontend/discourse/tests/integration/components/search-menu-test.gjs b/frontend/discourse/tests/integration/components/search-menu-test.gjs
index a0c7acd8831..56651d778f2 100644
--- a/frontend/discourse/tests/integration/components/search-menu-test.gjs
+++ b/frontend/discourse/tests/integration/components/search-menu-test.gjs
@@ -4,6 +4,7 @@ import {
render,
settled,
triggerKeyEvent,
+ waitUntil,
} from "@ember/test-helpers";
import { module, test } from "qunit";
import SearchMenu, {
@@ -70,7 +71,20 @@ module("Integration | Component | SearchMenu", function (hooks) {
await triggerKeyEvent("#icon-search-input", "keydown", "Escape");
- assert.dom(".menu-panel").doesNotExist("Menu panel is gone");
+ // Wait for the panel to actually be removed.
+ const menuClosed = await waitUntil(
+ () => !document.querySelector(".menu-panel")
+ ).catch(() => false);
+
+ // If it didn't close, print out focus state in the failure message.
+ let closeDebug = "";
+ if (!menuClosed) {
+ const panelCount = document.querySelectorAll(".menu-panel").length;
+ const { activeElement } = document;
+ closeDebug = ` (activeElement=${activeElement?.id || activeElement?.nodeName}, hasFocus=${document.hasFocus()}, panelCount=${panelCount})`;
+ }
+
+ assert.dom(".menu-panel").doesNotExist(`Menu panel is closed${closeDebug}`);
await click("#icon-search-input");
await click("#icon-search-input");