A platform for community discussion. Free, open, simple.
SECURITY: Escape assignment display name in crawler/print topic view (#43971)
David Battersby0eaa6e3d4bbf
diff --git a/app/views/topics/show.html.erb b/app/views/topics/show.html.erbindex 649592e50a0..18df22745b6 100644--- a/app/views/topics/show.html.erb+++ b/app/views/topics/show.html.erb@@ -87,7 +87,7 @@small_action_href = post_custom_fields["action_code_path"] || ""if post.action_code%>- <%= t("js.action_codes.#{post.action_code}", when: "", who: who_username, href: small_action_href).html_safe %>+ <%= t("js.action_codes.#{post.action_code}", when: "", who: ERB::Util.html_escape(who_username), href: small_action_href).html_safe %><% end %></span>diff --git a/plugins/discourse-assign/spec/requests/crawler_spec.rb b/plugins/discourse-assign/spec/requests/crawler_spec.rbnew file mode 100644index 00000000000..5117838b746--- /dev/null+++ b/plugins/discourse-assign/spec/requests/crawler_spec.rb@@ -0,0 +1,42 @@+# frozen_string_literal: true++RSpec.describe "Assignment crawler rendering" do+ fab!(:topic) { Fabricate(:post).topic }+ fab!(:attacker, :user)+ fab!(:assignable_group, :group)++ before do+ SiteSetting.assign_enabled = true+ SiteSetting.assigns_public = true+ SiteSetting.assign_allowed_on_groups = assignable_group.id.to_s+ SiteSetting.max_prints_per_hour_per_user = 10+ SiteSetting.prioritize_full_name_in_ux = true+ assignable_group.add(attacker)+ end++ it "escapes a self-assigned user's display name in the unauthenticated print view" do+ xss_payload = "<img src=x onerror=alert(1)>"++ sign_in(attacker)+ put "/u/#{attacker.username}.json", params: { name: xss_payload }++ expect(response.status).to eq(200)++ put "/assign/assign.json",+ params: {+ target_id: topic.id,+ target_type: "Topic",+ username: attacker.username,+ note: "Taking this",+ }++ expect(response.status).to eq(200)++ sign_out+ get "/t/#{topic.slug}/#{topic.id}/print", headers: { HTTP_USER_AGENT: "Rails Testing" }++ expect(response.status).to eq(200)+ expect(response.body).to include(ERB::Util.html_escape(xss_payload))+ expect(response.body).not_to include(xss_payload)+ end+end