Skip to content

A platform for community discussion. Free, open, simple.

DEV: Correct the server-reflexive candidate assumption in live ICE config (#45532)

Rafael dos Santos Silva0f920c7be16d
diff --git a/plugins/live/lib/live/ice_config.rb b/plugins/live/lib/live/ice_config.rb
index 10942e7d957..274c9312f5d 100644
--- a/plugins/live/lib/live/ice_config.rb
+++ b/plugins/live/lib/live/ice_config.rb
@@ -54,8 +54,11 @@ module Live
# A TURN-only setup with static credentials keeps the historical
# relay-only behavior. Secret-authenticated TURN keeps the policy at
- # "all" even without STUN: server-reflexive candidates come from the
- # (authenticated) TURN allocation, so direct connections still work.
+ # "all" even without STUN URLs, since browsers can learn their
+ # server-reflexive address from the TURN server. Some only learn it from a
+ # separate, always unauthenticated, Binding request, so the TURN server
+ # must not require authentication for STUN (coturn's secure-stun) or
+ # those browsers end up relayed.
def self.transport_policy
ephemeral_active = ephemeral_turn_urls.any? && SiteSetting.live_turn_secret.present?