Skip to content

A platform for community discussion. Free, open, simple.

FIX: Reviewable Insights Metadata (#42145)

Bannon Tanner14197fbdae87
diff --git a/app/serializers/reviewable_serializer.rb b/app/serializers/reviewable_serializer.rb
index 0aee54468b4..fde3007d2ac 100644
--- a/app/serializers/reviewable_serializer.rb
+++ b/app/serializers/reviewable_serializer.rb
@@ -26,8 +26,8 @@ class ReviewableSerializer < ApplicationSerializer
attribute :status_for_database, key: :status
- has_one :created_by, serializer: UserWithCustomFieldsSerializer, root: "users"
has_one :target_created_by, root: "users"
+ has_one :created_by, serializer: UserWithCustomFieldsSerializer, root: "users"
has_one :target_deleted_by, serializer: BasicUserSerializer, root: "users"
has_one :topic, serializer: ListableTopicSerializer
has_many :editable_fields, serializer: ReviewableEditableFieldSerializer, embed: :objects
diff --git a/spec/serializers/reviewable_serializer_spec.rb b/spec/serializers/reviewable_serializer_spec.rb
index 18be85a4c09..bc24b68619f 100644
--- a/spec/serializers/reviewable_serializer_spec.rb
+++ b/spec/serializers/reviewable_serializer_spec.rb
@@ -67,6 +67,17 @@ RSpec.describe ReviewableSerializer do
json = described_class.new(reviewable_user, scope: Guardian.new(admin), root: nil).as_json
expect(json[:target_created_by_id]).to eq(reviewable_user.target.id)
end
+
+ it "includes FlaggedUserSerializer fields when the flagger is also the post author" do
+ post = Fabricate(:post, user: admin)
+ reviewable = PostActionCreator.off_topic(admin, post).reviewable
+
+ json = ReviewableFlaggedPostSerializer.new(reviewable, scope: Guardian.new(admin)).as_json
+ target_user = json["users"].find { |u| u[:id] == admin.id }
+
+ expect(target_user).to be_present
+ expect(target_user).to include(:created_at, :post_count, :trust_level)
+ end
end
describe "target_deleted_by" do