Skip to content

A platform for community discussion. Free, open, simple.

DEV: Add missing original_filename to is_still_too_big? error (#38554)

Isaac Janzen163e65e3d0a9
diff --git a/lib/upload_creator.rb b/lib/upload_creator.rb
index 5ff25a061ba..4bccef90832 100644
--- a/lib/upload_creator.rb
+++ b/lib/upload_creator.rb
@@ -483,6 +483,7 @@ class UploadCreator
I18n.t(
"upload.images.larger_than_x_megapixels",
max_image_megapixels: SiteSetting.max_image_megapixels,
+ original_filename: @upload.original_filename,
),
)
true
diff --git a/spec/models/upload_spec.rb b/spec/models/upload_spec.rb
index 6fcfcc06a90..e0f65414cc6 100644
--- a/spec/models/upload_spec.rb
+++ b/spec/models/upload_spec.rb
@@ -273,19 +273,6 @@ RSpec.describe Upload do
expect(upload.thumbnail_width).to eq(nil)
end
- it "returns error when image resolution is to big" do
- SiteSetting.max_image_megapixels = 10
- upload = UploadCreator.new(huge_image, "image.png").create_for(user_id)
- expect(upload.persisted?).to eq(false)
- expect(upload.errors.messages[:base].first).to eq(
- I18n.t(
- "upload.images.larger_than_x_megapixels",
- max_image_megapixels: 10,
- original_filename: upload.original_filename,
- ),
- )
- end
-
it "extracts file extension" do
created_upload = UploadCreator.new(image, image_filename).create_for(user_id)
expect(created_upload.extension).to eq("png")