A platform for community discussion. Free, open, simple.
DEV: Introduce deprecation for `.hbs` file extension (#38757)
David Taylor17c696234de9
diff --git a/frontend/asset-processor/rollup-plugins/discourse-hbs.js b/frontend/asset-processor/rollup-plugins/discourse-hbs.jsindex 1669c2e20d2..64beadf833e 100644--- a/frontend/asset-processor/rollup-plugins/discourse-hbs.js+++ b/frontend/asset-processor/rollup-plugins/discourse-hbs.js@@ -9,6 +9,15 @@ export default function discourseHbs() {code: `import { hbs } from 'ember-cli-htmlbars';export default hbs(${JSON.stringify(input)}, { moduleName: ${JSON.stringify(id)} });++ import deprecated from 'discourse/lib/deprecated';+ deprecated(+ "The file '${id}' uses the deprecated .hbs extension. Refactor it to use '.gjs' instead.",+ {+ id: "discourse.hbs-extension",+ url: "https://meta.discourse.org/t/398896",+ }+ );`,map: null,};diff --git a/lib/asset_processor.rb b/lib/asset_processor.rbindex a7b1f49446a..da5378a9341 100644--- a/lib/asset_processor.rb+++ b/lib/asset_processor.rb@@ -1,7 +1,7 @@# frozen_string_literal: trueclass AssetProcessor- BASE_COMPILER_VERSION = 104+ BASE_COMPILER_VERSION = 105PROCESSOR_DIR = "tmp/asset-processor"LOCK_FILE = "#{PROCESSOR_DIR}/build.lock"diff --git a/spec/lib/asset_processor_spec.rb b/spec/lib/asset_processor_spec.rbindex 813c4819906..44734fa5498 100644--- a/spec/lib/asset_processor_spec.rb+++ b/spec/lib/asset_processor_spec.rb@@ -223,7 +223,10 @@ RSpec.describe AssetProcessor do},},)- expect(result["main.js"]["code"]).to include("createTemplateFactory")+ code = result["main.js"]["code"]+ expect(code).to include("createTemplateFactory")+ expect(code).to include("deprecated(")+ expect(code).to include('id: "discourse.hbs-extension"')endit "handles colocation" do