A platform for community discussion. Free, open, simple.
SECURITY: Leakage of hidden tags to unauthorized users (#42218)
Isaac Janzen189e5625a122
diff --git a/app/controllers/published_pages_controller.rb b/app/controllers/published_pages_controller.rbindex 675880842dc..26acd9fe9c4 100644--- a/app/controllers/published_pages_controller.rb+++ b/app/controllers/published_pages_controller.rb@@ -44,7 +44,7 @@ class PublishedPagesController < ApplicationController"published-page",params[:slug],"topic-#{@topic.id}",- @topic.tags.pluck(:name),+ @topic.tags.visible(guardian).pluck(:name),].flatten.compact,)diff --git a/spec/requests/published_pages_controller_spec.rb b/spec/requests/published_pages_controller_spec.rbindex 9cf146cf103..bd97932bf43 100644--- a/spec/requests/published_pages_controller_spec.rb+++ b/spec/requests/published_pages_controller_spec.rb@@ -137,6 +137,23 @@ RSpec.describe PublishedPagesController do)end+ it "omits hidden tags from body classes" do+ hidden_tag = Fabricate(:tag, name: "admins-only")+ hidden_tag_group =+ Fabricate(:tag_group, name: "Admins only", tag_names: [hidden_tag.name])+ hidden_tag_group.permissions = [+ [Group::AUTO_GROUPS[:admins], TagGroupPermission.permission_types[:full]],+ ]+ hidden_tag_group.save!+ published_page.topic.tags << hidden_tag++ get published_page.path++ expect(response.status).to eq(200)+ expect(response.body).to include("recipes")+ expect(response.body).not_to include(hidden_tag.name)+ end+context "when login is required" dobefore doSiteSetting.login_required = true