A platform for community discussion. Free, open, simple.
DEV: Restore "no decimal in integer setting" test (#39456)
Jarek Radosz19374472fd7a
diff --git a/frontend/discourse/tests/integration/components/site-setting-test.gjs b/frontend/discourse/tests/integration/components/site-setting-test.gjsindex cc25b464efe..234845f1051 100644--- a/frontend/discourse/tests/integration/components/site-setting-test.gjs+++ b/frontend/discourse/tests/integration/components/site-setting-test.gjs@@ -1,11 +1,5 @@-import {- click,- fillIn,- render,- triggerEvent,- typeIn,-} from "@ember/test-helpers";-import { module, skip, test } from "qunit";+import { click, fillIn, render, triggerEvent } from "@ember/test-helpers";+import { module, test } from "qunit";import SiteSettingComponent from "discourse/admin/components/site-setting";import SiteSetting from "discourse/admin/models/site-setting";import { setupRenderingTest } from "discourse/tests/helpers/component-test";@@ -113,22 +107,31 @@ module("Integration | Component | SiteSetting", function (hooks) {.hasText("jpg, jpeg, png, gif, heic, heif, webp, avif, svg");});- // Skipping for now because ember-test-helpers doesn't check for defaultPrevented when firing that event chain- skip("prevents decimal in integer setting input", async function (assert) {- this.set(- "setting",- SiteSetting.create({- setting: "suggested_topics_unread_max_days_old",- value: "",- type: "integer",- })- );+ test("prevents decimal in integer setting input", async function (assert) {+ const setting = SiteSetting.create({+ setting: "suggested_topics_unread_max_days_old",+ value: "",+ type: "integer",+ });await render(- <template><SiteSettingComponent @setting={{this.setting}} /></template>+ <template><SiteSettingComponent @setting={{setting}} /></template>);- await typeIn(".input-setting-integer", "90,5", { delay: 1000 });- assert.dom(".input-setting-integer").hasValue("905");++ const input = document.querySelector(".input-setting-integer");+ const isPrevented = (key) => {+ const event = new KeyboardEvent("keydown", {+ key,+ bubbles: true,+ cancelable: true,+ });+ input.dispatchEvent(event);+ return event.defaultPrevented;+ };++ assert.true(isPrevented(","), "prevents ,");+ assert.true(isPrevented("."), "prevents .");+ assert.false(isPrevented("9"), "allows 9");});test("does not consider an integer setting overridden if the value is the same as the default", async function (assert) {@@ -200,7 +203,7 @@ module("Integration | Component | SiteSetting", function (hooks) {);});- test("Shows update status for default_categories_ sitesettings", async function (assert) {+ test("Shows update status for default_categories_* site settings", async function (assert) {this.set("setting",SiteSetting.create({@@ -234,7 +237,7 @@ module("Integration | Component | SiteSetting", function (hooks) {assert.dom(".desc.site-setting").hasTextContaining("Update completed");});- test("Shows update status for default_tags_ sitesettings", async function (assert) {+ test("Shows update status for default_tags_* site settings", async function (assert) {this.set("setting",SiteSetting.create({