Skip to content

A platform for community discussion. Free, open, simple.

DEV: Fix flaky JsSandbox memory limit spec (#41859)

Renato Atilio19e4d4b04c87
diff --git a/plugins/discourse-workflows/spec/lib/discourse_workflows/js_sandbox_spec.rb b/plugins/discourse-workflows/spec/lib/discourse_workflows/js_sandbox_spec.rb
index 4bc16831083..c0981f649bc 100644
--- a/plugins/discourse-workflows/spec/lib/discourse_workflows/js_sandbox_spec.rb
+++ b/plugins/discourse-workflows/spec/lib/discourse_workflows/js_sandbox_spec.rb
@@ -26,10 +26,14 @@ RSpec.describe DiscourseWorkflows::JsSandbox do
describe "memory limit" do
it "raises when JS allocates too much memory" do
- expect { sandbox.eval(<<~JS) }.to raise_error(DiscourseWorkflows::JsSandbox::SandboxError)
+ # a generous timeout keeps the memory cap as the only limit that can
+ # fire, even on a slow CI box
+ stub_const(DiscourseWorkflows::JsSandbox, :EVAL_TIMEOUT_MS, 5_000) do
+ expect { sandbox.eval(<<~JS) }.to raise_error(DiscourseWorkflows::JsSandbox::SandboxError)
var a = [];
- while(true) { a.push(new Array(10000).fill('x')); }
+ while(true) { a.push(new Array(100000).fill(1.5)); }
JS
+ end
end
end