Skip to content

A platform for community discussion. Free, open, simple.

DEV: Avoid repeated setup in translation integrity specs (#43442)

Martin Brennan1eddd4554d51
diff --git a/spec/integrity/i18n_spec.rb b/spec/integrity/i18n_spec.rb
index 995e314b062..3c5586de98c 100644
--- a/spec/integrity/i18n_spec.rb
+++ b/spec/integrity/i18n_spec.rb
@@ -85,19 +85,12 @@ RSpec.describe "i18n integrity checks" do
locale = extract_locale(path)
yaml = load_yaml(path)
- it "has no duplicate keys" do
+ it "has valid translation YAML", :aggregate_failures do
duplicates = DuplicateKeyFinder.new.find_duplicates(path)
expect(duplicates).to be_empty
- end
-
- it "does not overwrite another locale" do
expect(yaml.keys).to eq([locale])
- end
- unless path["transliterate"]
- it "is compatible with english" do
- expect(is_yaml_compatible?(english_yaml, yaml)).to eq(true)
- end
+ expect(is_yaml_compatible?(english_yaml, yaml)).to eq(true) unless path["transliterate"]
end
end
end