A platform for community discussion. Free, open, simple.
DEV: Fix job serialization deprecation in d-automation (#39286)
Jarek Radosz2018dfb149c8
diff --git a/plugins/automation/app/jobs/scheduled/discourse_automation/tracker.rb b/plugins/automation/app/jobs/scheduled/discourse_automation/tracker.rbindex 0ad2f54aec3..e8c47f47daa 100644--- a/plugins/automation/app/jobs/scheduled/discourse_automation/tracker.rb+++ b/plugins/automation/app/jobs/scheduled/discourse_automation/tracker.rb@@ -67,7 +67,7 @@ module Jobspending_automation.automation.trigger!("kind" => pending_automation.automation.trigger,- "execute_at" => pending_automation.execute_at.iso8601,+ "execute_at" => pending_automation.execute_at,)pending_automation.destroy!diff --git a/plugins/automation/app/models/discourse_automation/automation.rb b/plugins/automation/app/models/discourse_automation/automation.rbindex d84889dc107..e599a99b032 100644--- a/plugins/automation/app/models/discourse_automation/automation.rb+++ b/plugins/automation/app/models/discourse_automation/automation.rb@@ -130,6 +130,8 @@ module DiscourseAutomationnew_context["_serialized_#{k}"] = { "class" => "Symbol", "value" => v.to_s }elsif v.is_a?(ActiveRecord::Base)new_context["_serialized_#{k}"] = { "class" => v.class.name, "id" => v.id }+ elsif v.is_a?(Date) || v.is_a?(Time)+ new_context[k] = v.iso8601elsenew_context[k] = venddiff --git a/plugins/automation/spec/models/automation_spec.rb b/plugins/automation/spec/models/automation_spec.rbindex e9026a2ae17..eacf4aa722a 100644--- a/plugins/automation/spec/models/automation_spec.rb+++ b/plugins/automation/spec/models/automation_spec.rb@@ -72,7 +72,7 @@ describe DiscourseAutomation::Automation doendend- context "when automation’s script has a field with validor" do+ context "when automation’s script has a field with validator" dobefore doDiscourseAutomation::Scriptable.add("required_dogs") dofield :dog, component: :text, validator: ->(input) { "must have dog" if input != "dog" }@@ -164,6 +164,28 @@ describe DiscourseAutomation::Automation doendend+ describe ".serialize_context" do+ it "serializes date and time as iso8601" do+ expect(+ described_class.serialize_context(+ {+ "time" => Time.utc(2026, 4, 15, 12, 0, 0),+ "time_with_zone" => Time.utc(2026, 4, 15, 12, 0, 0).in_time_zone("Europe/Warsaw"),+ "date_time" => DateTime.new(2026, 4, 15, 12, 0, 0),+ "date" => Date.new(2026, 4, 15),+ },+ ),+ ).to eq(+ {+ "time" => "2026-04-15T12:00:00Z",+ "time_with_zone" => "2026-04-15T14:00:00+02:00",+ "date_time" => "2026-04-15T12:00:00+00:00",+ "date" => "2026-04-15",+ },+ )+ end+ end+describe "after_destroy" dofab!(:automation) { Fabricate(:automation, enabled: false) }fab!(:automation2) { Fabricate(:automation, enabled: false) }