A platform for community discussion. Free, open, simple.
FIX: allow my route for alphanumeric params (#39605)
David Battersby26caa831de1d
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rbindex d3726926183..53e1f51eee6 100644--- a/app/controllers/users_controller.rb+++ b/app/controllers/users_controller.rb@@ -493,7 +493,7 @@ class UsersController < ApplicationControllerenddef my_redirect- raise Discourse::NotFound if params[:path] !~ %r{\A[a-zA-Z_\-/]+\z}+ raise Discourse::NotFound if params[:path] !~ %r{\A[a-zA-Z0-9_\-/]+\z}if current_user.blank?cookies[:destination_url] = path("/my/#{params[:path]}")diff --git a/spec/requests/users_controller_spec.rb b/spec/requests/users_controller_spec.rbindex b313eb4ad3a..26ebf349e91 100644--- a/spec/requests/users_controller_spec.rb+++ b/spec/requests/users_controller_spec.rb@@ -4204,6 +4204,11 @@ RSpec.describe UsersController doget "/my/messages/group/#{group.name}"expect(response).to redirect_to("/u/#{user1.username}/messages/group/#{group.name}")end++ it "works with alphanumeric params" do+ get "/my/messages/tags/example-123"+ expect(response).to redirect_to("/u/#{user1.username}/messages/tags/example-123")+ endendend