Skip to content

A platform for community discussion. Free, open, simple.

UX: fix alignment of topic list header tab (#40655)

Kris2a011af1b4aa
diff --git a/app/assets/stylesheets/common/base/uc-modernize-foundation-theme/buttons-controls.scss b/app/assets/stylesheets/common/base/uc-modernize-foundation-theme/buttons-controls.scss
index d0775a7f86c..04e7796d249 100644
--- a/app/assets/stylesheets/common/base/uc-modernize-foundation-theme/buttons-controls.scss
+++ b/app/assets/stylesheets/common/base/uc-modernize-foundation-theme/buttons-controls.scss
@@ -40,7 +40,8 @@
.composer-actions-btn,
.language-switcher-trigger,
.d-multi-select-trigger__expand-btn,
- .emoji-picker-trigger
+ .emoji-picker-trigger,
+ .topic-list-header-tab
) {
padding-block: 0;
height: var(--d-control-height);
diff --git a/app/assets/stylesheets/common/components/more-topics.scss b/app/assets/stylesheets/common/components/more-topics.scss
index 66101edca0c..68f2fa0f847 100644
--- a/app/assets/stylesheets/common/components/more-topics.scss
+++ b/app/assets/stylesheets/common/components/more-topics.scss
@@ -25,7 +25,6 @@
padding: var(--d-topic-list-header-data-padding-y) 0.8em;
border: none;
border-radius: 0;
- font-size: var(--d-topic-list-data-font-size);
line-height: var(--line-height-medium);
.d-icon {
diff --git a/frontend/discourse/app/components/topic-list/header/topic-cell.gjs b/frontend/discourse/app/components/topic-list/header/topic-cell.gjs
index 8dc3cc94c4d..ec219a3c1a4 100644
--- a/frontend/discourse/app/components/topic-list/header/topic-cell.gjs
+++ b/frontend/discourse/app/components/topic-list/header/topic-cell.gjs
@@ -2,6 +2,7 @@ import Component from "@glimmer/component";
import { fn } from "@ember/helper";
import { service } from "@ember/service";
import DButton from "discourse/ui-kit/d-button";
+import dConcatClass from "discourse/ui-kit/helpers/d-concat-class";
import SortableColumn from "./sortable-column";
export default class TopicCell extends Component {
@@ -22,7 +23,10 @@ export default class TopicCell extends Component {
@translatedLabel={{tab.name}}
@translatedTitle={{tab.name}}
@icon={{tab.icon}}
- class={{if (this.moreTopicsTabs.isActiveTab tab) "active"}}
+ class={{dConcatClass
+ "topic-list-header-tab"
+ (if (this.moreTopicsTabs.isActiveTab tab) "active")
+ }}
tabindex={{if (this.moreTopicsTabs.isActiveTab tab) -1 0}}
/>
</li>