A platform for community discussion. Free, open, simple.
DEPS: Bump omniauth-twitter from 1.4.0 to 1.5.0 (#43303)
dependabot[bot]2be4f02aaa06
diff --git a/.licensed.yml b/.licensed.ymlindex eb813c555b7..2c2e9cccc58 100644--- a/.licensed.yml+++ b/.licensed.yml@@ -46,6 +46,8 @@ ignored:reviewed:bundler:- activerecord # MIT+ - anonymous_loader # MIT+ - auth-sanitizer # MIT- benchmark # Ruby- coderay # MIT- concurrent-ruby # MIT@@ -71,6 +73,8 @@ reviewed:- net-pop # Ruby (bundled gem)- net-smtp # Ruby (bundled gem)- nio4r # MIT + BSD+ - oauth # MIT+ - oauth-tty # MIT- omniauth # MIT- pg # Ruby- pitchfork # Ruby or GPLv2/GPLv3diff --git a/Gemfile.lock b/Gemfile.lockindex 6490f199dbc..0067a71ae64 100644--- a/Gemfile.lock+++ b/Gemfile.lock@@ -108,9 +108,11 @@ GEMannotaterb (4.20.0)activerecord (>= 6.0.0)activesupport (>= 6.0.0)+ anonymous_loader (0.1.3)+ version_gem (~> 1.1, >= 1.1.14)ast (2.4.3)- auth-sanitizer (0.1.4)- version_gem (~> 1.1, >= 1.1.9)+ auth-sanitizer (0.2.3)+ version_gem (~> 1.1, >= 1.1.14)aws-eventstream (1.4.0)aws-partitions (1.1283.0)aws-sdk-bedrockruntime (1.83.0)@@ -408,17 +410,17 @@ GEMracc (~> 1.4)nokogiri (1.19.4-x86_64-linux-musl)racc (~> 1.4)- oauth (1.1.5)- auth-sanitizer (~> 0.1, >= 0.1.3)+ oauth (1.1.8)+ anonymous_loader (~> 0.1, >= 0.1.3)+ auth-sanitizer (~> 0.2, >= 0.2.3)base64 (~> 0.1)- cgi- oauth-tty (~> 1.0, >= 1.0.8)- snaky_hash (~> 2.0, >= 2.0.4)- version_gem (~> 1.1, >= 1.1.9)- oauth-tty (1.0.8)- auth-sanitizer (~> 0.1, >= 0.1.3)- cgi- version_gem (~> 1.1, >= 1.1.9)+ oauth-tty (~> 1.0, >= 1.0.13)+ snaky_hash (~> 2.0, >= 2.0.7)+ version_gem (~> 1.1, >= 1.1.14)+ oauth-tty (1.0.13)+ anonymous_loader (~> 0.1, >= 0.1.3)+ auth-sanitizer (~> 0.2, >= 0.2.3)+ version_gem (~> 1.1, >= 1.1.14)oauth2 (1.4.11)faraday (>= 0.17.3, < 3.0)jwt (>= 1.0, < 3.0)@@ -453,8 +455,9 @@ GEMomniauth-oauth2 (1.7.3)oauth2 (>= 1.4, < 3)omniauth (>= 1.9, < 3)- omniauth-twitter (1.4.0)- omniauth-oauth (~> 1.1)+ omniauth-twitter (1.5.0)+ cgi+ omniauth-oauth (~> 1.2)rackopenssl (3.3.2)openssl-signature_algorithm (1.3.0)@@ -996,8 +999,9 @@ CHECKSUMSaddressable (2.9.0) sha256=7fdf6ac3660f7f4e867a0838be3f6cf722ace541dd97767fa42bc6cfa980c7afafm (1.0.0) sha256=5bd4d6f6241e7014ef090985ec6f4c3e9745f6de0828ddd58bc1efdd138f4545annotaterb (4.20.0) sha256=871b2e898d1d60c23bdc59b72a5b840678a56355bf5f6fdeb8c79d317ff98bf7+ anonymous_loader (0.1.3) sha256=084a18e2439144d955447dc11dfc982f41fcd1583ad32d4d55151325dc44cb55ast (2.4.3) sha256=954615157c1d6a382bc27d690d973195e79db7f55e9765ac7c481c60bdb4d383- auth-sanitizer (0.1.4) sha256=ded72221d4d3a7c91e34e8a87b21e6a42cbf7829697f140dcf49d542422faedc+ auth-sanitizer (0.2.3) sha256=db10aac92cfbe4c64ab637eebcbe1d67395d1694798041362173370f59933e3caws-eventstream (1.4.0) sha256=116bf85c436200d1060811e6f5d2d40c88f65448f2125bc77ffce5121e6e183baws-partitions (1.1283.0) sha256=125ba9cb65eb7ec2b0a2041a47d204d403b3f6d9aa62bffa53a6b95b04b1f1deaws-sdk-bedrockruntime (1.83.0) sha256=6e47a53f890fadd8e572335b933d13cd09530f8e63fc6c99fbb608c048936cb9@@ -1161,8 +1165,8 @@ CHECKSUMSnokogiri (1.19.4-x86_64-darwin) sha256=7fd17057d3e1f00e9954a74b3cd76595d3d4a5ef233b7ed9599047c204f70551nokogiri (1.19.4-x86_64-linux-gnu) sha256=379fae440b28915e3f19d752ce2dcf8465ed2b2fbefd2a7ca0dd497bc981a06anokogiri (1.19.4-x86_64-linux-musl) sha256=17dfb7c1fa194ae02fbf7c51a7afc8d278045ab3fdacfd86f91d02d7b274470b- oauth (1.1.5) sha256=0ec467908f5819a54d1659d33e8bb520e8475cc87a452d6ecfaa5db351999cca- oauth-tty (1.0.8) sha256=d9a63b67af17c22517f868c59f12178e4ee19a367536d1a6dcb74d9d07a41e07+ oauth (1.1.8) sha256=7bf0b774391af4f820a86ce2cc7fa38c3fad5121b5563592535cff4b2e16d50e+ oauth-tty (1.0.13) sha256=71ad5f93ceea6fd21fe9a731dc02a4b892c5de9d77e0b303e81bd73f9daeb4a3oauth2 (1.4.11) sha256=6739fcc8872bc94f476b0cae3e8bd78a56d8364b1b79b0757794c25e152d5c10octokit (10.0.0) sha256=82e99a539b7637b7e905e6d277bb0c1a4bed56735935cc33db6da7eae49a24e8oj (3.17.6) sha256=f511257e01a12030c3ceb8023cd2e96fca924ea9c741f57ea366816f1fd8e68c@@ -1172,7 +1176,7 @@ CHECKSUMSomniauth-google-oauth2 (1.0.1) sha256=2ed7a4ac8d98ab824c95e0d6760784abf1248262b3ba2ab56ec7ebd7074d12a6omniauth-oauth (1.2.1) sha256=25bf22c90234280fa825200490f03ff1ce7d76f1a4fbd6c882c6c5b169c58da8omniauth-oauth2 (1.7.3) sha256=3f5a8f99fa72e0f91d2abd7475ceb972a4ae67ed59e049f314c0c1bad81f4745- omniauth-twitter (1.4.0) sha256=c5cc6c77cd767745ffa9ebbd5fbd694a3fa99d1d2d82a4d7def0bf3b6131b264+ omniauth-twitter (1.5.0) sha256=f7d488524113b2f654e1d7f722790dc03d92102cb7c947331ad2d68340a362e3openssl (3.3.2) sha256=7f4e01215dc9c4be1fca71d692406be3e6340b39c1f71a47fea9c497decd0f6copenssl-signature_algorithm (1.3.0) sha256=a3b40b5e8276162d4a6e50c7c97cdaf1446f9b2c3946a6fa2c14628e0c957e80optimist (3.2.1) sha256=8cf8a0fd69f3aa24ab48885d3a666717c27bc3d9edd6e976e18b9d771e72e34ediff --git a/spec/integration/twitter_omniauth_spec.rb b/spec/integration/twitter_omniauth_spec.rbindex e9383def2b2..55e00b08be7 100644--- a/spec/integration/twitter_omniauth_spec.rb+++ b/spec/integration/twitter_omniauth_spec.rb@@ -54,7 +54,7 @@ describe "Twitter OAuth 1.0a" doverified: true,email: email,}- stub_request(:get, "https://api.twitter.com/1.1/account/verify_credentials.json").with(+ stub_request(:get, "https://api.x.com/1.1/account/verify_credentials.json").with(query: {include_email: true,include_entities: false,@@ -68,7 +68,7 @@ describe "Twitter OAuth 1.0a" doSiteSetting.twitter_consumer_key = consumer_keySiteSetting.twitter_consumer_secret = consumer_secret- stub_request(:post, "https://api.twitter.com/oauth/request_token").to_return(+ stub_request(:post, "https://api.x.com/oauth/request_token").to_return(status: 200,body:Rack::Utils.build_query(@@ -80,7 +80,7 @@ describe "Twitter OAuth 1.0a" do"Content-Type" => "application/x-www-form-urlencoded",},)- stub_request(:post, "https://api.twitter.com/oauth/access_token").to_return(+ stub_request(:post, "https://api.x.com/oauth/access_token").to_return(status: 200,body:Rack::Utils.build_query(@@ -95,7 +95,7 @@ describe "Twitter OAuth 1.0a" doit "signs in the user if the API response from twitter includes an email (implies it's verified) and the email matches an existing user's" dopost "/auth/twitter"expect(response.status).to eq(302)- expect(response.location).to start_with("https://api.twitter.com/oauth/authenticate")+ expect(response.location).to start_with("https://api.x.com/oauth/authenticate")setup_twitter_email_stub(email: user1.email)@@ -112,7 +112,7 @@ describe "Twitter OAuth 1.0a" doSiteSetting.enable_discourse_connect = truepost "/auth/twitter"expect(response.status).to eq(302)- expect(response.location).to start_with("https://api.twitter.com/oauth/authenticate")+ expect(response.location).to start_with("https://api.x.com/oauth/authenticate")setup_twitter_email_stub(email: user1.email)@@ -125,7 +125,7 @@ describe "Twitter OAuth 1.0a" doit "doesn't sign in anyone if the API response from twitter doesn't include an email (implying the user's email on twitter isn't verified)" dopost "/auth/twitter"expect(response.status).to eq(302)- expect(response.location).to start_with("https://api.twitter.com/oauth/authenticate")+ expect(response.location).to start_with("https://api.x.com/oauth/authenticate")setup_twitter_email_stub(email: nil)diff --git a/spec/lib/auth/twitter_authenticator_spec.rb b/spec/lib/auth/twitter_authenticator_spec.rbindex 263708810ee..3f1c3f201b2 100644--- a/spec/lib/auth/twitter_authenticator_spec.rb+++ b/spec/lib/auth/twitter_authenticator_spec.rb@@ -68,7 +68,7 @@ RSpec.describe Auth::TwitterAuthenticator dodescribe "#healthy?" dolet(:authenticator) { described_class.new }- let(:request_token_url) { "https://api.twitter.com/oauth/request_token" }+ let(:request_token_url) { "https://api.x.com/oauth/request_token" }before doSiteSetting.twitter_consumer_key = "key"