Skip to content

A platform for community discussion. Free, open, simple.

DEV: Enable route-splitting for discourse-workflows (#43073)

David Taylor2d27a69a2742
diff --git a/plugins/discourse-workflows/about.json b/plugins/discourse-workflows/about.json
new file mode 100644
index 00000000000..ec86a3934cc
--- /dev/null
+++ b/plugins/discourse-workflows/about.json
@@ -0,0 +1,5 @@
+{
+ "frontend": {
+ "staticModules": true
+ }
+}
diff --git a/plugins/discourse-workflows/admin/assets/javascripts/admin/discourse-workflows-route-map.js b/plugins/discourse-workflows/admin/assets/javascripts/admin/discourse-workflows-route-map.js
index a90767a6428..de8138997b0 100644
--- a/plugins/discourse-workflows/admin/assets/javascripts/admin/discourse-workflows-route-map.js
+++ b/plugins/discourse-workflows/admin/assets/javascripts/admin/discourse-workflows-route-map.js
@@ -1,6 +1,8 @@
export default {
resource: "admin.adminPlugins.show",
path: "/plugins",
+ bundleName: "workflows-admin",
+
map() {
this.route("discourse-workflows", { path: "workflows" }, function () {
this.route("new");
diff --git a/plugins/discourse-workflows/admin/assets/javascripts/admin/lib/workflows/node-output-schemas.js b/plugins/discourse-workflows/admin/assets/javascripts/admin/lib/workflows/node-output-schemas.js
index c9743c1c23e..b8d1c4539d6 100644
--- a/plugins/discourse-workflows/admin/assets/javascripts/admin/lib/workflows/node-output-schemas.js
+++ b/plugins/discourse-workflows/admin/assets/javascripts/admin/lib/workflows/node-output-schemas.js
@@ -1,26 +1,13 @@
+import summarize from "./output-schemas/summarize";
+
// Nodes whose output keys come from what the author typed cannot declare them as a contract, so
// they compute them in Ruby and name an editor-side counterpart through `output_schema_resolver`.
-const RESOLVER_MODULE = /\/admin\/lib\/workflows\/output-schemas\/([\w-]+)$/;
-
-let cache;
-
-function resolverFor(name) {
- cache ??= Object.keys(require.entries).reduce((resolvers, moduleName) => {
- const match = moduleName.match(RESOLVER_MODULE);
- if (match) {
- resolvers[match[1]] = moduleName;
- }
- return resolvers;
- }, {});
-
- const moduleName = cache[name];
- return moduleName ? require(moduleName).default : null;
-}
+const RESOLVERS = { summarize };
export function outputSchemasFromResolver(resolver, configuration = {}) {
if (!resolver) {
return null;
}
- return resolverFor(resolver)?.(configuration || {}) || null;
+ return RESOLVERS[resolver]?.(configuration || {}) || null;
}
diff --git a/plugins/discourse-workflows/assets/javascripts/discourse/discourse-workflows-public-route-map.js b/plugins/discourse-workflows/assets/javascripts/discourse/discourse-workflows-public-route-map.js
index e095f2bd8de..29df2b10232 100644
--- a/plugins/discourse-workflows/assets/javascripts/discourse/discourse-workflows-public-route-map.js
+++ b/plugins/discourse-workflows/assets/javascripts/discourse/discourse-workflows-public-route-map.js
@@ -1,4 +1,10 @@
export default function () {
- this.route("workflows-form", { path: "/workflows/form/:uuid" });
- this.route("workflows-form-test", { path: "/workflows/form-test/:token" });
+ this.route("workflows-form", {
+ path: "/workflows/form/:uuid",
+ bundleName: "workflows-form",
+ });
+ this.route("workflows-form-test", {
+ path: "/workflows/form-test/:token",
+ bundleName: "workflows-form",
+ });
}