A platform for community discussion. Free, open, simple.
DEV: Use playwright api in csv download spec (#39765)
Jarek Radosz2d640d58adf8
diff --git a/spec/system/helpers/downloads.rb b/spec/system/helpers/downloads.rbindex c124e5ac0c8..ca4f397f6e4 100644--- a/spec/system/helpers/downloads.rb+++ b/spec/system/helpers/downloads.rb@@ -2,24 +2,6 @@class DownloadsFOLDER = Rails.root.join("tmp/downloads")- TIMEOUT = 10-- # Waits for `path` to appear and finish writing.- def self.wait_for(path)- previous_size = -1- Timeout.timeout(TIMEOUT) do- loop do- size = File.size?(path)- break if size == previous_size-- previous_size = size if size- sleep 0.1- end- end- rescue Timeout::Error- last = previous_size == -1 ? "never appeared" : "last size #{previous_size}"- raise Timeout::Error, "Timed out after #{TIMEOUT}s waiting for #{path} (#{last})"- enddef self.clearFileUtils.rm_rf(FOLDER)diff --git a/spec/system/page_objects/pages/csv_export_pm.rb b/spec/system/page_objects/pages/csv_export_pm.rbindex af407ee4406..b1b630e2c2e 100644--- a/spec/system/page_objects/pages/csv_export_pm.rb+++ b/spec/system/page_objects/pages/csv_export_pm.rb@@ -9,21 +9,18 @@ module PageObjectsenddef download_and_extract- original_save_path = Capybara.save_path- Capybara.save_path = Downloads::FOLDER-zip_name = find("a.attachment").textzip_path = File.join(Downloads::FOLDER, zip_name)@downloaded_files << zip_path- click_link ".zip"- Downloads.wait_for(zip_path)+ page.driver.with_playwright_page do |pw_page|+ download = pw_page.expect_download { click_link ".zip" }+ download.save_as(zip_path)+ endcsv_path = unzip(zip_path).first@downloaded_files << csv_pathCSV.read(csv_path)- ensure- Capybara.save_path = original_save_pathenddef clear_downloads