Skip to content

A platform for community discussion. Free, open, simple.

DEV: Fix an array shim deprecation false-positive (#40538)

Jarek Radosz2ddc44f7626e
diff --git a/frontend/discourse/app/array-shim.js b/frontend/discourse/app/array-shim.js
index 0e3e7a62fff..6a12d8037ac 100644
--- a/frontend/discourse/app/array-shim.js
+++ b/frontend/discourse/app/array-shim.js
@@ -88,7 +88,10 @@ function wrapSquareBracketDescriptor() {
// eslint-disable-next-line no-extend-native
Object.defineProperty(Array.prototype, propertyName, {
get() {
- warn(propertyName, "getter");
+ // Reading `[]` on `Array.prototype` itself isn't an issue.
+ if (this !== Array.prototype) {
+ warn(propertyName, "getter");
+ }
return withSilencedDeprecations(SILENCED_ARRAY_DEPRECATIONS, () =>
squareBracketDescriptor.get.bind(this)()