Skip to content

A platform for community discussion. Free, open, simple.

DEV: Enable Playwright soft reset by default in system tests (#41895)

Alan Guo Xiang Tan305676d70e92
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index b2c4825abda..76a8c3a10a1 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -54,7 +54,6 @@ jobs:
CAPYBARA_DEFAULT_MAX_WAIT_TIME: 20
MINIO_RUNNER_LOG_LEVEL: WARN
DISCOURSE_TURBO_RSPEC_RETRY_AND_LOG_FLAKY_TESTS: ${{ (matrix.build_type == 'system' || matrix.build_type == 'backend') && '1' }}
- CAPYBARA_PLAYWRIGHT_SOFT_RESET: ${{ matrix.build_type == 'system' && '1' }}
CHEAP_SOURCE_MAPS: "1"
DBUS_SESSION_BUS_ADDRESS: "unix:path=/dev/null"
MINIO_RUNNER_INSTALL_DIR: /home/discourse/.minio_runner
diff --git a/spec/support/system/capybara_patches.rb b/spec/support/system/capybara_patches.rb
index d41368301d7..84f54a1d499 100644
--- a/spec/support/system/capybara_patches.rb
+++ b/spec/support/system/capybara_patches.rb
@@ -258,7 +258,7 @@ module PlaywrightSoftReset
private
def soft_reset_enabled?
- return false if ENV["CAPYBARA_PLAYWRIGHT_SOFT_RESET"] != "1"
+ return false if ENV["CAPYBARA_PLAYWRIGHT_SOFT_RESET"] == "0"
!(callback_on_save_screenrecord? || @callback_on_save_trace)
end
end