A platform for community discussion. Free, open, simple.
UX: hljs language selector sorting (#38704)
Martin Brennan30fd6f47b40a
diff --git a/frontend/discourse/app/static/prosemirror/extensions/code-block.js b/frontend/discourse/app/static/prosemirror/extensions/code-block.jsindex 0bbce0b2882..ef957a638d6 100644--- a/frontend/discourse/app/static/prosemirror/extensions/code-block.js+++ b/frontend/discourse/app/static/prosemirror/extensions/code-block.js@@ -49,7 +49,7 @@ class CodeBlockWithLangSelectorNodeView {select.addEventListener("change", (e) => this.changeListener(e));select.classList.add("code-language-select");- const languages = hljs.listLanguages();+ const languages = hljs.listLanguages().sort((a, b) => a.localeCompare(b));const empty = document.createElement("option");empty.textContent = languages.includes(this.node.attrs.params)diff --git a/frontend/discourse/tests/integration/components/prosemirror-editor/code-block-test.js b/frontend/discourse/tests/integration/components/prosemirror-editor/code-block-test.jsindex c8748b8af0a..151259d0b02 100644--- a/frontend/discourse/tests/integration/components/prosemirror-editor/code-block-test.js+++ b/frontend/discourse/tests/integration/components/prosemirror-editor/code-block-test.js@@ -54,5 +54,26 @@ module(await testMarkdown(assert, markdown, html, expectedMarkdown, true);});});++ test("language selector options are alphabetically sorted", async function (assert) {+ await testMarkdown(+ assert,+ "```\nconsole.log('Hello, world!');\n```",+ () => {+ const options = [+ ...document.querySelectorAll(".code-language-select option"),+ ]+ .slice(1)+ .map((option) => option.textContent);++ assert.deepEqual(+ options,+ [...options].sort((a, b) => a.localeCompare(b))+ );+ },+ "```\nconsole.log('Hello, world!');\n```",+ true+ );+ });});