A platform for community discussion. Free, open, simple.
FIX: Generate 4096-bit RSA keys for private themes (#44603)
Penar Musaraj326163f18c00
diff --git a/app/controllers/admin/themes_controller.rb b/app/controllers/admin/themes_controller.rbindex fc4bc319fe0..56bbaed377d 100644--- a/app/controllers/admin/themes_controller.rb+++ b/app/controllers/admin/themes_controller.rb@@ -36,7 +36,7 @@ class Admin::ThemesController < Admin::AdminControllerdef generate_key_pairrequire "sshkey"- k = SSHKey.generate+ k = SSHKey.generate(bits: 4096)Discourse.redis.setex("ssh_key_#{k.ssh_public_key}", 1.hour, k.private_key)render json: { public_key: k.ssh_public_key }enddiff --git a/spec/requests/admin/themes_controller_spec.rb b/spec/requests/admin/themes_controller_spec.rbindex 0350a828a01..b4be33d9b39 100644--- a/spec/requests/admin/themes_controller_spec.rb+++ b/spec/requests/admin/themes_controller_spec.rb@@ -19,13 +19,15 @@ RSpec.describe Admin::ThemesController docontext "when logged in as an admin" dobefore { sign_in(admin) }- it "can generate key pairs" do+ it "generates 4096-bit RSA key pairs" dopost "/admin/themes/generate_key_pair.json"expect(response.status).to eq(200)json = response.parsed_bodyexpect(json["private_key"]).to eq(nil)expect(json["public_key"]).to include("ssh-rsa ")- expect(Discourse.redis.get("ssh_key_#{json["public_key"]}")).not_to eq(nil)+ private_key = Discourse.redis.get("ssh_key_#{json["public_key"]}")+ expect(OpenSSL::PKey::RSA.new(private_key).n.num_bits).to eq(4096)+ expect(SSHKey.new(private_key).ssh_public_key).to eq(json["public_key"])endend