A platform for community discussion. Free, open, simple.
DEV: Allow adding anonymous_users to styleguide_allowed_groups again (#43052)
Sérgio Saquetim32a8515c6ad2
diff --git a/plugins/styleguide/config/settings.yml b/plugins/styleguide/config/settings.ymlindex 6902841d2a3..21e9c9c535e 100644--- a/plugins/styleguide/config/settings.yml+++ b/plugins/styleguide/config/settings.yml@@ -10,6 +10,5 @@ plugins:client: falseallow_any: falserefresh: true- disallowed_groups: "4"validator: "AtLeastOneGroupValidator"area: "group_permissions"diff --git a/plugins/styleguide/spec/integration/access_spec.rb b/plugins/styleguide/spec/integration/access_spec.rbindex f1d8570528e..01f0876b9aa 100644--- a/plugins/styleguide/spec/integration/access_spec.rb+++ b/plugins/styleguide/spec/integration/access_spec.rb@@ -34,6 +34,15 @@ RSpec.describe "SiteSetting.styleguide_allowed_groups" doexpect(response.status).to eq(404)end+ context "when styleguide_allowed_groups includes anonymous_users" do+ before { SiteSetting.styleguide_allowed_groups = "#{Group::AUTO_GROUPS[:anonymous_users]}" }++ it "shows the styleguide" do+ get "/styleguide"+ expect(response.status).to eq(200)+ end+ end+context "when granular_anonymous_and_logged_in_groups_permissions is not enabled" dobefore { SiteSetting.granular_anonymous_and_logged_in_groups_permissions = false }diff --git a/plugins/styleguide/spec/requests/styleguide/styleguide_controller_spec.rb b/plugins/styleguide/spec/requests/styleguide/styleguide_controller_spec.rbindex 7c34680fe86..13820b61f32 100644--- a/plugins/styleguide/spec/requests/styleguide/styleguide_controller_spec.rb+++ b/plugins/styleguide/spec/requests/styleguide/styleguide_controller_spec.rb@@ -4,6 +4,24 @@ RSpec.describe Styleguide::StyleguideController dobefore { SiteSetting.styleguide_enabled = true }describe "#index" do+ context "when styleguide_allowed_groups includes anonymous and logged in users" do+ before do+ SiteSetting.styleguide_allowed_groups =+ "#{Group::AUTO_GROUPS[:anonymous_users]}|#{Group::AUTO_GROUPS[:logged_in_users]}"+ end++ it "allows access for anonymous users" do+ get "/styleguide"+ expect(response.status).to eq(200)+ end++ it "allows access for logged in users" do+ sign_in(Fabricate(:user))+ get "/styleguide"+ expect(response.status).to eq(200)+ end+ end+context "when styleguide_allowed_groups is set to staff" dobefore { SiteSetting.styleguide_allowed_groups = Group::AUTO_GROUPS[:staff] }diff --git a/plugins/styleguide/spec/system/smoke_test_spec.rb b/plugins/styleguide/spec/system/smoke_test_spec.rbindex 05b7e5076f0..f7da1683188 100644--- a/plugins/styleguide/spec/system/smoke_test_spec.rb+++ b/plugins/styleguide/spec/system/smoke_test_spec.rb@@ -212,6 +212,19 @@ RSpec.describe "Styleguide Smoke Test" doendend+ context "when the styleguide is enabled for everyone" do+ before do+ Capybara.reset_sessions!+ SiteSetting.styleguide_allowed_groups = Group::AUTO_GROUPS[:anonymous_users]+ end++ it "renders a page using HighlightedCode for anonymous users" do+ visit "/styleguide/atoms/font-scale"+ expect(styleguide).to have_heading("Font System")+ expect(page).to have_css("code.hljs")+ end+ end+context "when the styleguide is only enabled for staff" dobefore { SiteSetting.styleguide_allowed_groups = Group::AUTO_GROUPS[:staff] }