Skip to content

A platform for community discussion. Free, open, simple.

DEV: bump new post reaction menu to stable (#40270)

David Battersby32e53b0d8eba
diff --git a/config/site_settings.yml b/config/site_settings.yml
index a556813a80d..9b8d8005a75 100644
--- a/config/site_settings.yml
+++ b/config/site_settings.yml
@@ -4434,7 +4434,7 @@ experimental:
hidden: true
area: "experimental"
upcoming_change:
- status: "beta"
+ status: "stable"
impact: "feature,all_members"
learn_more_url: "https://meta.discourse.org/t/-/389820"
rename_faq_to_guidelines:
diff --git a/plugins/discourse-reactions/spec/system/reactions_post_spec.rb b/plugins/discourse-reactions/spec/system/reactions_post_spec.rb
index 99e8102fca2..b9d3c04d4aa 100644
--- a/plugins/discourse-reactions/spec/system/reactions_post_spec.rb
+++ b/plugins/discourse-reactions/spec/system/reactions_post_spec.rb
@@ -109,8 +109,9 @@ describe "Reactions | Post reactions" do
end
end
- context "when hovering over a reaction whose value contains a URL-reserved character" do
+ context "when clicking a reaction whose value contains a URL-reserved character" do
fab!(:other_user, :user)
+ let(:popup) { PageObjects::Components::PostReactionsPopup.new }
before do
DiscourseReactions::ReactionManager.new(
@@ -120,13 +121,14 @@ describe "Reactions | Post reactions" do
).toggle!
end
- it "loads the reaction users in the hover popup" do
+ it "loads the reaction users in the popup" do
visit post_2.url
expect(reactions_list).to have_reaction("+1")
- reactions_list.hover_over_reaction("+1")
+ reactions_list.click_reaction("+1")
- expect(reactions_list).to have_users_for_reaction("+1", [other_user.username])
+ expect(popup).to be_open
+ expect(popup).to have_user(other_user.username)
end
end
end