Skip to content

A platform for community discussion. Free, open, simple.

SECURITY: Channel member list exposes other users' chat read state and notification settings (#40884)

Isaac Janzen37a303ad3f59
diff --git a/plugins/chat/app/controllers/chat/api/channels_memberships_controller.rb b/plugins/chat/app/controllers/chat/api/channels_memberships_controller.rb
index d8f34c9f386..b7f486bd2c2 100644
--- a/plugins/chat/app/controllers/chat/api/channels_memberships_controller.rb
+++ b/plugins/chat/app/controllers/chat/api/channels_memberships_controller.rb
@@ -19,7 +19,7 @@ class Chat::Api::ChannelsMembershipsController < Chat::Api::ChannelsController
render_serialized(
memberships,
- Chat::UserChannelMembershipSerializer,
+ Chat::MemberListChannelMembershipSerializer,
root: "memberships",
meta: {
total_rows: channel_from_params.user_count,
diff --git a/plugins/chat/app/serializers/chat/member_list_channel_membership_serializer.rb b/plugins/chat/app/serializers/chat/member_list_channel_membership_serializer.rb
new file mode 100644
index 00000000000..1d23e28870b
--- /dev/null
+++ b/plugins/chat/app/serializers/chat/member_list_channel_membership_serializer.rb
@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module Chat
+ class MemberListChannelMembershipSerializer < ApplicationSerializer
+ has_one :user, embed: :objects
+
+ def user
+ user = object.user || Chat::NullUser.new
+ Chat::BasicUserSerializer.new(user, root: false, scope: scope, include_status: true)
+ end
+ end
+end
diff --git a/plugins/chat/spec/requests/chat/api/channels_memberships_controller_spec.rb b/plugins/chat/spec/requests/chat/api/channels_memberships_controller_spec.rb
index b009743d794..c578bec431d 100644
--- a/plugins/chat/spec/requests/chat/api/channels_memberships_controller_spec.rb
+++ b/plugins/chat/spec/requests/chat/api/channels_memberships_controller_spec.rb
@@ -15,6 +15,31 @@ RSpec.describe Chat::Api::ChannelsMembershipsController do
sign_in(current_user)
end
+ describe "#index" do
+ it "does not expose other users' membership state" do
+ chat_message = Fabricate(:chat_message, chat_channel: channel_1, user: other_user)
+ other_membership = channel_1.membership_for(other_user)
+ other_membership.update!(
+ following: false,
+ muted: true,
+ notification_level: :never,
+ last_read_message_id: chat_message.id,
+ last_viewed_at: 1.hour.ago,
+ last_viewed_pins_at: 30.minutes.ago,
+ starred: true,
+ )
+
+ get "/chat/api/channels/#{channel_1.id}/memberships"
+
+ expect(response.status).to eq(200)
+ membership =
+ response.parsed_body["memberships"].find { |item| item.dig("user", "id") == other_user.id }
+
+ expect(membership.dig("user", "username")).to eq(other_user.username)
+ expect(membership.keys).to contain_exactly("user")
+ end
+ end
+
describe "#create" do
describe "success" do
it "works" do