A platform for community discussion. Free, open, simple.
DEV: Handle missing urls in prosemirror/image (#39163)
Jarek Radosz380427708f53
diff --git a/frontend/discourse/app/static/prosemirror/extensions/image.js b/frontend/discourse/app/static/prosemirror/extensions/image.jsindex 01e3d448536..c3acab9f4db 100644--- a/frontend/discourse/app/static/prosemirror/extensions/image.js+++ b/frontend/discourse/app/static/prosemirror/extensions/image.js@@ -1,6 +1,7 @@import {lookupCachedUploadUrl,lookupUncachedUploadUrls,+ MISSING,} from "pretty-text/upload-short-url";import { ajax } from "discourse/lib/ajax";import discourseDebounce from "discourse/lib/debounce";@@ -227,7 +228,9 @@ const extension = {for (const { src } of unresolvedUrls) {const cachedUrl = lookupCachedUploadUrl(src).url;- if (cachedUrl) {+ if (cachedUrl === MISSING) {+ continue;+ } else if (cachedUrl) {resolvedUrls[src] = cachedUrl;} else {uncachedSrcs.push(src);diff --git a/frontend/pretty-text/addon/upload-short-url.js b/frontend/pretty-text/addon/upload-short-url.jsindex 08854e4c5f7..d80b3c30b15 100644--- a/frontend/pretty-text/addon/upload-short-url.js+++ b/frontend/pretty-text/addon/upload-short-url.js@@ -8,7 +8,7 @@ export function lookupCachedUploadUrl(shortUrl) {return _cache[shortUrl] || {};}-const MISSING = "missing";+export const MISSING = "missing";export function lookupUncachedUploadUrls(urls, ajax) {urls = urls.filter(Boolean);