A platform for community discussion. Free, open, simple.
FIX: Hide git signature output when reading commit date (#42613)
Seori Konno3c95ee01d5de
diff --git a/lib/git_utils.rb b/lib/git_utils.rbindex ff00cec886a..ccd38a3c57b 100644--- a/lib/git_utils.rb+++ b/lib/git_utils.rb@@ -22,7 +22,7 @@ class GitUtilsenddef self.last_commit_date- git_cmd = 'git log -1 --format="%ct"'+ git_cmd = "git rev-list -1 --no-commit-header --format=%ct HEAD"seconds = try_git(git_cmd, nil)seconds.nil? ? nil : DateTime.strptime(seconds, "%s")enddiff --git a/spec/lib/git_utils_spec.rb b/spec/lib/git_utils_spec.rbindex 390abd06c64..bbe17deb331 100644--- a/spec/lib/git_utils_spec.rb+++ b/spec/lib/git_utils_spec.rb@@ -59,6 +59,17 @@ RSpec.describe GitUtils doendend+ describe ".last_commit_date" do+ it "reads the commit timestamp without commit headers" do+ timestamp = "1786671289"+ GitUtils+ .expects(:try_git)+ .with("git rev-list -1 --no-commit-header --format=%ct HEAD", nil)+ .returns(timestamp)+ expect(GitUtils.last_commit_date).to eq(DateTime.strptime(timestamp, "%s"))+ end+ end+describe ".has_commit?" doit "validates commit existence and format" dowithin_temp_git_repo do