A platform for community discussion. Free, open, simple.
DEV: Fix `send_keys`-related spec flakes (#39714)
Jarek Radosz3e78007bc465
diff --git a/spec/system/composer/prosemirror_links_spec.rb b/spec/system/composer/prosemirror_links_spec.rbindex 8e9c2ac5cd7..5de6b14ceb2 100644--- a/spec/system/composer/prosemirror_links_spec.rb+++ b/spec/system/composer/prosemirror_links_spec.rb@@ -21,6 +21,7 @@ describe "Composer - ProseMirror - Links" docomposer.type_content("[Example](https://example.com)")composer.send_keys(:left, :left, :left)# Use Tab to navigate to the toolbar and Enter to activate edit+ expect(page).to have_css("[data-identifier='composer-link-toolbar']")composer.send_keys(:tab, :enter)expect(upsert_hyperlink_modal).to be_openexpect(upsert_hyperlink_modal.link_text_value).to eq("Example")@@ -39,6 +40,7 @@ describe "Composer - ProseMirror - Links" docomposer.type_content("[Example](https://example.com)")composer.send_keys(:left, :left, :left)# Use Tab to navigate to the toolbar and Enter to activate edit+ expect(page).to have_css("[data-identifier='composer-link-toolbar']")composer.send_keys(:tab, :enter)expect(upsert_hyperlink_modal).to be_openexpect(upsert_hyperlink_modal.link_text_value).to eq("Example")@@ -166,6 +168,7 @@ describe "Composer - ProseMirror - Links" docomposer.type_content("[Party :tada: Time](https://example.com)")composer.send_keys(:left, :left, :left)# Use Tab to navigate to the toolbar and Enter to activate edit+ expect(page).to have_css("[data-identifier='composer-link-toolbar']")composer.send_keys(:tab, :enter)expect(upsert_hyperlink_modal).to be_openexpect(upsert_hyperlink_modal.link_text_value).to eq("Party :tada: Time")@@ -184,6 +187,7 @@ describe "Composer - ProseMirror - Links" docomposer.type_content("[**Bold** and *italic* text](https://example.com)")composer.send_keys(:left, :left, :left)# Use Tab to navigate to the toolbar and Enter to activate edit+ expect(page).to have_css("[data-identifier='composer-link-toolbar']")composer.send_keys(:tab, :enter)expect(upsert_hyperlink_modal).to be_openexpect(upsert_hyperlink_modal.link_text_value).to eq("**Bold** and *italic* text")diff --git a/spec/system/page_objects/components/topic_list.rb b/spec/system/page_objects/components/topic_list.rbindex 3ad9e47752e..c51d90537cd 100644--- a/spec/system/page_objects/components/topic_list.rb+++ b/spec/system/page_objects/components/topic_list.rb@@ -42,6 +42,10 @@ module PageObjectspage.has_no_css?("#{topic_list_item_class(topic)} input#bulk-select-#{topic.id}")end+ def has_bulk_select_enabled?+ page.has_css?("#{TOPIC_LIST_ITEM_SELECTOR} input.bulk-select")+ end+def has_closed_status?(topic)page.has_css?("#{topic_list_item_closed(topic)}")enddiff --git a/spec/system/topic_bulk_select_spec.rb b/spec/system/topic_bulk_select_spec.rbindex b3ed53ecf9b..8924f1d6ef1 100644--- a/spec/system/topic_bulk_select_spec.rb+++ b/spec/system/topic_bulk_select_spec.rb@@ -348,6 +348,7 @@ describe "Topic bulk select" dovisit("/latest")send_keys([:shift, "b"])+ expect(topic_list).to have_bulk_select_enabledsend_keys("j")send_keys("x") # toggle selectexpect(topic_list).to have_checkbox_selected_on_row(1)@@ -366,6 +367,7 @@ describe "Topic bulk select" doexpect(topic_list).to have_topicssend_keys([:shift, "b"])+ expect(topic_list).to have_bulk_select_enabledsend_keys("j")send_keys("x")send_keys([:shift, "d"])