Skip to content

A platform for community discussion. Free, open, simple.

SECURITY: Invalidate topic AI summaries when a post is destroyed (#42945)

Sam3eb485d6efe5
diff --git a/plugins/discourse-ai/lib/summarization/entry_point.rb b/plugins/discourse-ai/lib/summarization/entry_point.rb
index 59fe2d2ac74..0976ad15445 100644
--- a/plugins/discourse-ai/lib/summarization/entry_point.rb
+++ b/plugins/discourse-ai/lib/summarization/entry_point.rb
@@ -99,6 +99,10 @@ module DiscourseAi
end
end
+ plugin.on(:post_destroyed) do |post|
+ AiSummary.where(target_type: "Topic", target_id: post.topic_id).delete_all
+ end
+
plugin.on(:posts_moved) do |args|
if SiteSetting.discourse_ai_enabled && SiteSetting.ai_summarization_enabled &&
!SiteSetting.ai_summary_backfill_maximum_topics_per_hour.zero?
diff --git a/plugins/discourse-ai/spec/requests/summarization/summary_controller_spec.rb b/plugins/discourse-ai/spec/requests/summarization/summary_controller_spec.rb
index 8038c43391c..bdedfa69e0a 100644
--- a/plugins/discourse-ai/spec/requests/summarization/summary_controller_spec.rb
+++ b/plugins/discourse-ai/spec/requests/summarization/summary_controller_spec.rb
@@ -145,6 +145,19 @@ RSpec.describe DiscourseAi::Summarization::SummaryController do
expect(response.status).to eq(403)
end
+ it "does not expose a cached summary after a post is soft-deleted" do
+ sensitive_content = "Content removed by staff"
+ post_2.update!(raw: sensitive_content)
+ summary = create_cached_summary(topic)
+ summary.update!(summarized_text: sensitive_content)
+
+ PostDestroyer.new(Fabricate(:admin), post_2).destroy
+
+ get "/discourse-ai/summarization/t/#{topic.id}.json"
+
+ expect(response.status).to eq(404)
+ end
+
it "returns a summary" do
summary_text = "This is a summary"