A platform for community discussion. Free, open, simple.
SECURITY: Unsanitized TagLocalization Descriptions (#41555)
Isaac Janzen3eee2ad5e767
diff --git a/app/models/tag_localization.rb b/app/models/tag_localization.rbindex 1579a959d83..89ab326f928 100644--- a/app/models/tag_localization.rb+++ b/app/models/tag_localization.rb@@ -2,10 +2,12 @@class TagLocalization < ActiveRecord::Baseinclude LocaleMatchable+ include HasSanitizableFieldsbelongs_to :tagbefore_validation :clean_name+ before_save :sanitize_descriptionvalidates :locale, presence: true, length: { maximum: 20 }validates :name, presence: true@@ -17,6 +19,10 @@ class TagLocalization < ActiveRecord::Basedef clean_nameself.name = DiscourseTagging.clean_tag(name) if name.present?end++ def sanitize_description+ self.description = sanitize_field(description) if description_changed?+ endend# == Schema Informationdiff --git a/spec/lib/tag_localization_creator_spec.rb b/spec/lib/tag_localization_creator_spec.rbindex 91aa5600199..3bcd4888570 100644--- a/spec/lib/tag_localization_creator_spec.rb+++ b/spec/lib/tag_localization_creator_spec.rb@@ -26,6 +26,18 @@ describe TagLocalizationCreator do)end+ it "sanitizes unsafe description HTML", :aggregate_failures do+ unsafe_description =+ '<script>alert("xss")</script><a href="https://example.com" onclick="alert(1)">link</a>'+ sanitized_description = Fabricate(:tag, description: unsafe_description).description++ localization =+ described_class.create(tag:, locale:, name:, description: unsafe_description, user:)++ expect(localization.description).to eq(sanitized_description)+ expect(localization.description).not_to match(/<script|onclick/i)+ end+it "creates localization without description" dolocalization = described_class.create(tag:, locale:, name:, user:)