Skip to content

A platform for community discussion. Free, open, simple.

FIX: Tag info leaks hidden synonym tag names and descriptions (#39779)

Sam3f9ac5234770
diff --git a/app/serializers/detailed_tag_serializer.rb b/app/serializers/detailed_tag_serializer.rb
index 1870b4d4dbf..522f8b6239b 100644
--- a/app/serializers/detailed_tag_serializer.rb
+++ b/app/serializers/detailed_tag_serializer.rb
@@ -6,7 +6,7 @@ class DetailedTagSerializer < TagSerializer
has_many :categories, serializer: BasicCategorySerializer
def synonyms
- TagsController.tag_counts_json(object.synonyms, scope)
+ TagsController.tag_counts_json(DiscourseTagging.filter_visible(object.synonyms, scope), scope)
end
def categories
diff --git a/spec/requests/tags_controller_spec.rb b/spec/requests/tags_controller_spec.rb
index 95843b1039d..e62d4c134e3 100644
--- a/spec/requests/tags_controller_spec.rb
+++ b/spec/requests/tags_controller_spec.rb
@@ -626,6 +626,28 @@ RSpec.describe TagsController do
)
end
+ context "when a synonym is hidden from the current user" do
+ fab!(:hidden_synonym) do
+ Fabricate(
+ :tag,
+ name: "hidden-synonym",
+ description: "private synonym description",
+ target_tag: tag,
+ )
+ end
+ fab!(:hidden_tag_group) do
+ Fabricate(:tag_group, permissions: { "staff" => 1 }, tags: [hidden_synonym])
+ end
+
+ it "does not expose the synonym" do
+ get "/tag/#{tag.name}/info.json"
+ expect(response.status).to eq(200)
+ expect(response.parsed_body.dig("tag_info", "synonyms")).to be_empty
+ expect(response.body).not_to include(hidden_synonym.name)
+ expect(response.body).not_to include(hidden_synonym.description)
+ end
+ end
+
it "returns 404 if tag is staff-only" do
_tag_group = Fabricate(:tag_group, permissions: { "staff" => 1 }, tag_names: ["test"])
get "/tag/test/info.json"