Skip to content

A platform for community discussion. Free, open, simple.

SECURITY: Stored XSS chat-transcript username unescaped in Rich Text Editor

Isaac Janzen3fb1e8ead0d4
diff --git a/plugins/chat/assets/javascripts/lib/rich-editor-extension.js b/plugins/chat/assets/javascripts/lib/rich-editor-extension.js
index 00e1dd5907d..875e03ff704 100644
--- a/plugins/chat/assets/javascripts/lib/rich-editor-extension.js
+++ b/plugins/chat/assets/javascripts/lib/rich-editor-extension.js
@@ -72,10 +72,15 @@ const extension = {
const formattedDateTime = moment(node.attrs.datetime).format(
i18n("dates.long_no_year")
);
- userElement.innerHTML = `
- <span class="chat-transcript-username">${node.attrs.username}</span>
- <span class="chat-transcript-datetime">${formattedDateTime}</span>
- `;
+ const usernameElement = document.createElement("span");
+ usernameElement.classList.add("chat-transcript-username");
+ usernameElement.textContent = node.attrs.username;
+ userElement.appendChild(usernameElement);
+
+ const datetimeElement = document.createElement("span");
+ datetimeElement.classList.add("chat-transcript-datetime");
+ datetimeElement.textContent = formattedDateTime;
+ userElement.appendChild(datetimeElement);
const messagesElement = document.createElement("div");
messagesElement.classList.add("chat-transcript-messages");
diff --git a/plugins/chat/test/javascripts/components/rich-editor-extension-test.gjs b/plugins/chat/test/javascripts/components/rich-editor-extension-test.gjs
index caf3ac3c4b3..9f841d3e31a 100644
--- a/plugins/chat/test/javascripts/components/rich-editor-extension-test.gjs
+++ b/plugins/chat/test/javascripts/components/rich-editor-extension-test.gjs
@@ -64,6 +64,24 @@ haha **ok** _cool_
assert.strictEqual(value, singleMessageSingleUserMarkdown);
});
+ test("escapes HTML in transcript usernames", async function (assert) {
+ const transcriptWithHtmlUsername = `[chat quote="<b>marker</b>;29856;2025-03-20T07:13:04Z"]
+haha
+[/chat]
+`;
+ await setupRichEditor(assert, transcriptWithHtmlUsername);
+
+ const rootElement = document.querySelector(
+ ".ProseMirror .chat-transcript"
+ );
+ assert
+ .dom(".chat-transcript-user .chat-transcript-username", rootElement)
+ .hasText("<b>marker</b>", "renders transcript username markup as text");
+ assert
+ .dom(".chat-transcript-user .chat-transcript-username b", rootElement)
+ .doesNotExist("does not render markup from transcript usernames");
+ });
+
test("multiple messages from multiple different users", async function (assert) {
const multiMessagesMultiUserMarkdown = `[chat quote="martin;29853;2025-03-20T07:12:55Z" channel="design gems :tada:" channelId=95 multiQuote=true chained=true]
test