Skip to content

A platform for community discussion. Free, open, simple.

FIX: Use a literal ellipsis in the category chooser placeholder (#45232)

Sérgio Saquetim433a5bdd01a5
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index 9de1b9da4b4..5cfecdd966d 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -5520,7 +5520,7 @@ en:
category:
none: "(no category)"
all: "All categories"
- choose: "Category…"
+ choose: "Category…"
edit: "Edit"
edit_title: "Edit this category"
edit_dialog_title: "Edit: %{categoryName}"
diff --git a/frontend/discourse/tests/acceptance/topic-edit-timer-test.js b/frontend/discourse/tests/acceptance/topic-edit-timer-test.js
index 6655e92104d..cd22d3915bc 100644
--- a/frontend/discourse/tests/acceptance/topic-edit-timer-test.js
+++ b/frontend/discourse/tests/acceptance/topic-edit-timer-test.js
@@ -141,7 +141,7 @@ acceptance("Topic - Edit timer", function (needs) {
assert.strictEqual(
categoryChooser.header().label(),
- i18n("category.choose").replace("…", "…")
+ i18n("category.choose")
);
assert.strictEqual(categoryChooser.header().value(), null);
@@ -176,7 +176,7 @@ acceptance("Topic - Edit timer", function (needs) {
assert.strictEqual(
categoryChooser.header().label(),
- i18n("category.choose").replace("…", "…")
+ i18n("category.choose")
);
assert.strictEqual(categoryChooser.header().value(), null);
@@ -216,7 +216,7 @@ acceptance("Topic - Edit timer", function (needs) {
assert.strictEqual(
categoryChooser.header().label(),
- i18n("category.choose").replace("…", "…")
+ i18n("category.choose")
);
assert.strictEqual(categoryChooser.header().value(), null);
diff --git a/frontend/discourse/tests/integration/components/select-kit/category-chooser-test.gjs b/frontend/discourse/tests/integration/components/select-kit/category-chooser-test.gjs
index 5d8263bba43..4528e340fcc 100644
--- a/frontend/discourse/tests/integration/components/select-kit/category-chooser-test.gjs
+++ b/frontend/discourse/tests/integration/components/select-kit/category-chooser-test.gjs
@@ -155,7 +155,12 @@ module(
assert.strictEqual(this.subject.header().value(), null);
assert.strictEqual(
this.subject.header().label(),
- i18n("category.choose").replace("…", "…")
+ i18n("category.choose")
+ );
+ assert.strictEqual(
+ this.subject.header().title(),
+ this.subject.header().label(),
+ "the tooltip reads like the label"
);
});
@@ -192,7 +197,7 @@ module(
assert.strictEqual(this.subject.header().value(), null);
assert.strictEqual(
this.subject.header().label(),
- i18n("category.choose").replace("…", "…")
+ i18n("category.choose")
);
});