A platform for community discussion. Free, open, simple.
DEV: Spec fix by removing repeated search (#43568)
Natalie Tay438ea4dea8cc
diff --git a/spec/system/admin_site_setting_locale_spec.rb b/spec/system/admin_site_setting_locale_spec.rbindex 2b4e8bdadf7..f4e807dde61 100644--- a/spec/system/admin_site_setting_locale_spec.rb+++ b/spec/system/admin_site_setting_locale_spec.rb@@ -16,17 +16,12 @@ describe "Admin Site Setting Locales" dosettings_page.visitsettings_page.type_in_search("default locale")- expect(settings_page.enum_setting("default_locale").value).to eq("es")+ expect(settings_page).to have_enum_value("default_locale", "es")settings_page.select_enum_value("default_locale", "en")settings_page.save_setting("default_locale")- settings_page.type_in_search("default locale")- expect(settings_page.enum_setting("default_locale").value).to eq("en")- expect(settings_page.find_setting("default_locale")).to have_css(- "option[value='en']",- text: "Inglés (English)",- )+ expect(settings_page).to have_enum_value("default_locale", "en", text: "Inglés (English)")endenddiff --git a/spec/system/page_objects/pages/admin_site_settings.rb b/spec/system/page_objects/pages/admin_site_settings.rbindex cec04dca509..72a1f21fe47 100644--- a/spec/system/page_objects/pages/admin_site_settings.rb+++ b/spec/system/page_objects/pages/admin_site_settings.rb@@ -52,6 +52,13 @@ module PageObjects)end+ def has_enum_value?(setting_name, value, text: nil)+ has_css?(+ "#{setting_row_selector(setting_name)} select option[value='#{value}']:checked",+ text:,+ )+ end+def has_setting?(setting_name)has_css?(".row.setting[data-setting=\"#{setting_name}\"]")end