Skip to content

A platform for community discussion. Free, open, simple.

A11Y: use list elements for tag list (#38731)

Kris43c568582fab
diff --git a/app/assets/stylesheets/common/base/menu-panel.scss b/app/assets/stylesheets/common/base/menu-panel.scss
index 92ab6dd5571..adc050f86ec 100644
--- a/app/assets/stylesheets/common/base/menu-panel.scss
+++ b/app/assets/stylesheets/common/base/menu-panel.scss
@@ -164,7 +164,7 @@
font-size: var(--font-down-1);
}
- div.discourse-tags {
+ .discourse-tags {
font-size: var(--font-down-1);
}
diff --git a/app/assets/stylesheets/common/base/tagging.scss b/app/assets/stylesheets/common/base/tagging.scss
index cab49c6437e..c5f4e1ff0fa 100644
--- a/app/assets/stylesheets/common/base/tagging.scss
+++ b/app/assets/stylesheets/common/base/tagging.scss
@@ -132,6 +132,13 @@
.discourse-tags {
display: inline-flex;
flex-wrap: wrap;
+ list-style: none;
+ margin: 0;
+
+ li {
+ display: inline-flex;
+ align-items: center;
+ }
&:has(.box) {
gap: var(--space-1);
diff --git a/frontend/discourse/app/lib/render-tags.js b/frontend/discourse/app/lib/render-tags.js
index cdb3ae627eb..18ed857ccdd 100644
--- a/frontend/discourse/app/lib/render-tags.js
+++ b/frontend/discourse/app/lib/render-tags.js
@@ -77,7 +77,7 @@ export default function (topic, params) {
classNames.push(params.className);
}
- buffer = `<div class='${classNames.join(" ")}' role='list' aria-label=${i18n("tagging.tags")}>`;
+ buffer = `<ul class='${classNames.join(" ")}' aria-label=${i18n("tagging.tags")}>`;
let currentIndex = 0;
@@ -91,6 +91,7 @@ export default function (topic, params) {
tagParams.extraClass = params.tagClasses[tagStr];
}
+ buffer += "<li>";
buffer += renderTag(tag, {
description: topic?.tags_descriptions?.[tagStr],
isPrivateMessage,
@@ -106,11 +107,13 @@ export default function (topic, params) {
buffer += separatorSpan(currentIndex);
currentIndex++;
}
+ buffer += "</li>";
}
}
// add custom results with separator
for (let i = 0; i < callbackResults.length; i++) {
+ buffer += "<li>";
buffer += callbackResults[i];
// don't add separator to the last item
@@ -118,9 +121,10 @@ export default function (topic, params) {
buffer += separatorSpan(currentIndex);
currentIndex++;
}
+ buffer += "</li>";
}
- buffer += "</div>";
+ buffer += "</ul>";
}
return buffer;