A platform for community discussion. Free, open, simple.
SECURITY: Group report details expose raw Data Explorer SQL to non-admin group members (#40919)
Bannon Tanner44bac11628ec
diff --git a/plugins/discourse-data-explorer/app/serializers/discourse_data_explorer/query_details_serializer.rb b/plugins/discourse-data-explorer/app/serializers/discourse_data_explorer/query_details_serializer.rbindex 8abb2eabd4a..d2e76970eb2 100644--- a/plugins/discourse-data-explorer/app/serializers/discourse_data_explorer/query_details_serializer.rb+++ b/plugins/discourse-data-explorer/app/serializers/discourse_data_explorer/query_details_serializer.rb@@ -4,6 +4,10 @@ module DiscourseDataExplorerclass QueryDetailsSerializer < QuerySerializerattributes :sql, :param_info, :created_at, :hidden+ def include_sql?+ scope&.is_admin?+ end+def param_infoobject&.params&.uniq { |p| p.identifier }&.map(&:to_hash)enddiff --git a/plugins/discourse-data-explorer/spec/requests/query_controller_spec.rb b/plugins/discourse-data-explorer/spec/requests/query_controller_spec.rbindex fb33a4de764..5c604a63e0a 100644--- a/plugins/discourse-data-explorer/spec/requests/query_controller_spec.rb+++ b/plugins/discourse-data-explorer/spec/requests/query_controller_spec.rb@@ -984,6 +984,47 @@ describe DiscourseDataExplorer::QueryController doendend+ describe "#group_reports_show SQL visibility" do+ fab!(:user)+ fab!(:moderator)+ fab!(:admin)+ fab!(:group) { Fabricate(:group, users: [user]) }++ it "omits SQL from group report details for group members" do+ sign_in(user)+ query = make_query("SELECT 1977 as leaked_value", {}, [group.id.to_s])++ get "/g/#{group.name}/reports/#{query.id}.json"++ expect(response.status).to eq(200)+ expect(response_json["query"]).not_to have_key("sql")+ expect(response.body).not_to include(query.sql)+ end++ it "omits SQL from group report details for moderators" do+ group.add(moderator)+ sign_in(moderator)+ query = make_query("SELECT 1984 as leaked_value", {}, [group.id.to_s])++ get "/g/#{group.name}/reports/#{query.id}.json"++ expect(response.status).to eq(200)+ expect(response_json["query"]).not_to have_key("sql")+ expect(response.body).not_to include(query.sql)+ end++ it "includes SQL in group report details for admins" do+ sign_in(admin)+ query = make_query("SELECT 1978 as admin_visible_value", {}, [group.id.to_s])++ get "/g/#{group.name}/reports/#{query.id}.json"++ expect(response.status).to eq(200)+ expect(response_json["query"]["sql"]).to eq(query.sql)+ expect(response.body).to include(query.sql)+ end+ end+describe "legacy /admin/plugins/explorer/ routes" dofab!(:admin)