Skip to content

A platform for community discussion. Free, open, simple.

DEV: Add host_lists for mappable list (#42983)

Natalie Tay451f8af66da9
diff --git a/lib/site_setting_extension.rb b/lib/site_setting_extension.rb
index da73c959238..63c989890ac 100644
--- a/lib/site_setting_extension.rb
+++ b/lib/site_setting_extension.rb
@@ -1227,7 +1227,7 @@ module SiteSettingExtension
# Same logic as above for other list type settings, with the caveat that normal
# list settings are not necessarily integers, so we just want to handle the splitting.
- if %i[list emoji_list tag_list].include?(type_supervisor.get_type(name))
+ if %i[list emoji_list tag_list host_list].include?(type_supervisor.get_type(name))
list_type = type_supervisor.get_list_type(name)
if %w[simple compact locale].include?(list_type) || list_type.nil?
diff --git a/spec/lib/site_setting_extension_spec.rb b/spec/lib/site_setting_extension_spec.rb
index 68883af0685..b2fd6487190 100644
--- a/spec/lib/site_setting_extension_spec.rb
+++ b/spec/lib/site_setting_extension_spec.rb
@@ -1881,6 +1881,11 @@ RSpec.describe SiteSettingExtension do
expect(SiteSetting.digest_suppress_tags_map).to eq(%w[blah blah2])
end
+ it "handles splitting host_list settings" do
+ SiteSetting.blocked_email_domains = "example.com|example.org"
+ expect(SiteSetting.blocked_email_domains_map).to eq(%w[example.com example.org])
+ end
+
it "handles blank values for settings" do
SiteSetting.ga_universal_auto_link_domains = ""
SiteSetting.pm_tags_allowed_for_groups = ""