Skip to content

A platform for community discussion. Free, open, simple.

FIX: Localize post excerpts in the latest posts feed

Régis Hanol458f078d9947
diff --git a/app/controllers/posts_controller.rb b/app/controllers/posts_controller.rb
index 0c44fcfb738..8aed19a47ee 100644
--- a/app/controllers/posts_controller.rb
+++ b/app/controllers/posts_controller.rb
@@ -83,7 +83,7 @@ class PostsController < ApplicationController
.visible
.where(post_type: Post.types[:regular])
.order(id: :desc)
- .includes(topic: :category)
+ .includes(topic: %i[category localizations])
.includes(user: %i[primary_group flair_group])
.includes(:reply_to_user)
.where("categories.id" => Category.secured(guardian).select(:id))
diff --git a/app/serializers/post_serializer.rb b/app/serializers/post_serializer.rb
index bbe318f4f0d..d6af3c2d8c0 100644
--- a/app/serializers/post_serializer.rb
+++ b/app/serializers/post_serializer.rb
@@ -153,6 +153,13 @@ class PostSerializer < BasicPostSerializer
ContentLocalization.translated_topic_fancy_title(topic, scope) || topic&.fancy_title
end
+ def excerpt
+ translated_cooked = ContentLocalization.translated_post_cooked(object, scope)
+ return object.excerpt if !translated_cooked
+
+ Post.excerpt(translated_cooked, nil, post: object)
+ end
+
def posts_count
topic&.posts_count
end
diff --git a/spec/requests/posts_controller_spec.rb b/spec/requests/posts_controller_spec.rb
index 8056cb17f33..730eb9e2864 100644
--- a/spec/requests/posts_controller_spec.rb
+++ b/spec/requests/posts_controller_spec.rb
@@ -4296,6 +4296,18 @@ RSpec.describe PostsController do
end
describe "#latest" do
+ it "returns the translated excerpt" do
+ viewer = Fabricate(:user, locale: "ja")
+ SiteSetting.content_localization_enabled = true
+ post = Fabricate(:post, raw: "Original post body", locale: "en")
+ Fabricate(:post_localization, post: post, locale: "ja", cooked: "<p>翻訳された本文</p>")
+
+ sign_in(viewer)
+ get "/posts.json"
+
+ expect(response.parsed_body["latest_posts"].first["excerpt"]).to eq("翻訳された本文")
+ end
+
context "with private posts" do
describe "when not logged in" do
it "should return the right response" do