Skip to content

A platform for community discussion. Free, open, simple.

DEV: Make GHSA comparisons case-insensitive

Loïc Guitaut47b32ca262ca
diff --git a/lib/tasks/release.rake b/lib/tasks/release.rake
index 7ce0a19dbaf..5388f94d8b4 100644
--- a/lib/tasks/release.rake
+++ b/lib/tasks/release.rake
@@ -226,8 +226,8 @@ namespace :release do
selected =
if (ghsa_ids = ENV["SECURITY_FIX_GHSA_IDS"])
- requested = ghsa_ids.split(",").map(&:strip)
- choices.select { |pr| pr["ghsa_id"] && requested.include?(pr["ghsa_id"]) }
+ requested = ghsa_ids.split(",").map(&:strip).map(&:downcase)
+ choices.select { |pr| pr["ghsa_id"] && requested.include?(pr["ghsa_id"].downcase) }
else
prompt = TTY::Prompt.new
prompt_choices =
diff --git a/spec/tasks/release_spec.rb b/spec/tasks/release_spec.rb
index ed552d30e44..1dae7931914 100644
--- a/spec/tasks/release_spec.rb
+++ b/spec/tasks/release_spec.rb
@@ -515,7 +515,7 @@ RSpec.describe "tasks/release" do
capture: true,
).and_return(pr_list_json)
- ENV["SECURITY_FIX_GHSA_IDS"] = "GHSA-1111-2222-3333,GHSA-aaaa-bbbb-cccc"
+ ENV["SECURITY_FIX_GHSA_IDS"] = "ghsa-1111-2222-3333,GHSA-aaaa-bbbb-cccc"
Dir.chdir(origin_path) do
git "checkout", "-b", "security-fix-one"