Skip to content

A platform for community discussion. Free, open, simple.

FIX: Hide timeline footer controls in the reply target picker

Régis Hanol48eb68bac986
diff --git a/app/assets/stylesheets/common/modal/change-reply-to.scss b/app/assets/stylesheets/common/modal/change-reply-to.scss
index 9516ad0ff76..0b0d7c2fbbc 100644
--- a/app/assets/stylesheets/common/modal/change-reply-to.scss
+++ b/app/assets/stylesheets/common/modal/change-reply-to.scss
@@ -37,7 +37,7 @@
// The timeline footer has "jump to post" and notification controls that
// are irrelevant inside this picker; hide them.
- .timeline-footer-controls {
+ &.show .topic-timeline .timeline-footer-controls {
display: none;
}
diff --git a/frontend/discourse/tests/acceptance/composer-reply-to-test.js b/frontend/discourse/tests/acceptance/composer-reply-to-test.js
index 285a585b520..bed4df26506 100644
--- a/frontend/discourse/tests/acceptance/composer-reply-to-test.js
+++ b/frontend/discourse/tests/acceptance/composer-reply-to-test.js
@@ -26,6 +26,7 @@ acceptance("Composer - Reply target picker", function (needs) {
locale: null,
})
);
+ server.get("/t/280/excerpts.json", () => helper.response([]));
});
async function openEditForReplyPost() {
@@ -52,5 +53,12 @@ acceptance("Composer - Reply target picker", function (needs) {
assert
.dom("[data-name='change-reply-to']")
.exists("the menu item is available for editors");
+
+ await click("[data-name='change-reply-to']");
+
+ assert
+ .dom(".change-reply-to-modal .timeline-footer-controls")
+ .exists()
+ .isNotVisible();
});
});