Skip to content

A platform for community discussion. Free, open, simple.

SECURITY: Prevent queued replies from adopting client-supplied category as review scope (#43978)

Keegan George49ef283b6d0f
diff --git a/lib/new_post_manager.rb b/lib/new_post_manager.rb
index a562a12d6e2..33c5ce38919 100644
--- a/lib/new_post_manager.rb
+++ b/lib/new_post_manager.rb
@@ -285,7 +285,7 @@ class NewPostManager
target_created_by: @user,
)
reviewable.payload["title"] = @args[:title] if @args[:title].present?
- reviewable.category_id = args[:category] if args[:category].present?
+ reviewable.category_id = args[:category] if @args[:topic_id].blank? && args[:category].present?
reviewable.created_new!
create_options = reviewable.create_options.merge(creator_opts)
diff --git a/spec/requests/posts_controller_spec.rb b/spec/requests/posts_controller_spec.rb
index 844fcc14c49..70accb15b2a 100644
--- a/spec/requests/posts_controller_spec.rb
+++ b/spec/requests/posts_controller_spec.rb
@@ -1987,6 +1987,34 @@ RSpec.describe PostsController do
end
end
+ it "prevents category-Y reviewers from approving a queued reply in category X" do
+ SiteSetting.enable_category_group_moderation = true
+ topic_category = Fabricate(:category)
+ topic_category.update!(require_reply_approval: true)
+ review_category = Fabricate(:category)
+ topic = Fabricate(:topic, category: topic_category)
+ review_group = Fabricate(:group)
+ reviewer = Fabricate(:user, refresh_auto_groups: true)
+ review_group.add(reviewer)
+ Fabricate(:category_moderation_group, category: review_category, group: review_group)
+
+ raw = "queued reply in category X"
+ post "/posts.json", params: { raw: raw, topic_id: topic.id, category: review_category.id }
+
+ expect(response.status).to eq(200)
+ expect(response.parsed_body["action"]).to eq("enqueued")
+ reviewable = ReviewableQueuedPost.find_by!(target_created_by: user)
+
+ sign_in(reviewer)
+ expect do
+ put "/review/#{reviewable.id}/perform/approve_post.json?version=#{reviewable.version}"
+ end.not_to change(Post, :count)
+
+ expect(response.status).to eq(403)
+ expect(response.body).not_to include(raw)
+ expect(reviewable.reload).to be_pending
+ end
+
it "silences correctly based on auto_silence_first_post_regex" do
SiteSetting.auto_silence_first_post_regex = "I love candy|i eat s[1-5]"