Skip to content

A platform for community discussion. Free, open, simple.

FIX: handle all networks splits in Gemini decoder (#44272)

Sam4a06c19335ef
diff --git a/plugins/discourse-ai/lib/completions/endpoints/gemini.rb b/plugins/discourse-ai/lib/completions/endpoints/gemini.rb
index 568e98b93f9..a4264bed176 100644
--- a/plugins/discourse-ai/lib/completions/endpoints/gemini.rb
+++ b/plugins/discourse-ai/lib/completions/endpoints/gemini.rb
@@ -383,6 +383,7 @@ module DiscourseAi
decoded =
lines
.map do |line|
+ line = line.sub(/\A[\r\n]+/, "")
if line.start_with?("data: {")
begin
JSON.parse(line[6..-1], symbolize_names: true)
diff --git a/plugins/discourse-ai/spec/lib/completions/endpoints/gemini_streaming_decoder_spec.rb b/plugins/discourse-ai/spec/lib/completions/endpoints/gemini_streaming_decoder_spec.rb
new file mode 100644
index 00000000000..02f05e9ade6
--- /dev/null
+++ b/plugins/discourse-ai/spec/lib/completions/endpoints/gemini_streaming_decoder_spec.rb
@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+RSpec.describe DiscourseAi::Completions::Endpoints::Gemini::GeminiStreamingDecoder do
+ before { enable_current_plugin }
+
+ describe "#decode" do
+ [
+ ["CRLF", "\r\n\r\n", 1],
+ ["CRLF", "\r\n\r\n", 2],
+ ["CRLF", "\r\n\r\n", 3],
+ ["LF", "\n\n", 1],
+ ].each do |line_ending, separator, split_position|
+ it "decodes all events when a chunk ends at byte #{split_position} of a #{line_ending} separator" do
+ decoder = described_class.new
+ events =
+ %w[A B C D].each_with_index.map do |text, index|
+ {
+ candidates: [{ content: { parts: [{ text: text }], role: "model" } }],
+ usageMetadata: {
+ candidatesTokenCount: [11, 38, 65, 95][index],
+ },
+ }
+ end
+ events.last[:candidates].first[:finishReason] = "STOP"
+ data_lines = events.map { |event| "data: #{event.to_json}" }
+ chunks = [
+ data_lines[0] + separator,
+ data_lines[1] + separator[0...split_position],
+ separator[split_position..] + data_lines[2] + separator,
+ data_lines[3] + separator,
+ ]
+
+ decoded = chunks.flat_map { |chunk| decoder.decode(chunk) }
+
+ expect(decoded).to eq(events)
+ end
+ end
+
+ it "decodes the same events at every possible chunk boundary" do
+ events = [
+ { candidates: [{ content: { parts: [{ text: "Hello" }], role: "model" } }] },
+ { candidates: [{ content: { parts: [{ text: " world" }], role: "model" } }] },
+ ]
+
+ ["\r\n\r\n", "\n\n"].each do |separator|
+ stream = events.map { |event| "data: #{event.to_json}#{separator}" }.join
+
+ (0..stream.bytesize).each do |split_position|
+ decoder = described_class.new
+ chunks = [stream[0...split_position], stream[split_position..]]
+
+ decoded = chunks.flat_map { |chunk| decoder.decode(chunk) }
+
+ expect(decoded).to eq(events),
+ "Failed at byte #{split_position} with separator #{separator.inspect}"
+ end
+ end
+ end
+ end
+end